[commit: base] master: Make 'forever' inlinable (fixes Trac #5205) (ae10342)

[Manuel M T Chakravarty]

I am still getting the same error when validating with Haddock enabled.

Manuel


Simon Peyton-Jones:
> Fixed by
> 
> commit d8d65a2939fbbab478c895de5f432cb0da869709
> Author: Simon Peyton Jones <simonpj at microsoft.com>
> Date:   Sat Jun 11 14:21:26 2011 +0100
> 
>    Without -O do not complain about SPECIALISE pragmas for non-INLINABLE things
> 
>    Otherwise Haddock (which compiles stuff without -O) falls over
> 
> |  -----Original Message-----
> |  From: cvs-libraries-bounces at haskell.org [mailto:cvs-libraries-bounces at haskell.org]
> |  On Behalf Of Simon Peyton-Jones
> |  Sent: 10 June 2011 21:08
> |  To: Manuel M T Chakravarty
> |  Cc: cvs-libraries at haskell.org
> |  Subject: RE: [commit: base] master: Make 'forever' inlinable (fixes Trac #5205)
> |  (ae10342)
> |  
> |  |  > libraries/base/GHC/ST.lhs:78:1:
> |  |  >     You cannot SPECIALISE `forever'
> |  |  >       because its definition has no INLINE/INLINABLE pragma
> |  |  >       (or you compiled its defining module without -O)
> |  |  > make[1]: *** [libraries/base/dist-install/doc/html/base/base.haddock] Error 1
> |  
> |  Oh, wait.  This is something to do with *haddock* (I see in the last line) which I may
> |  have switched off because it takes so long.
> |  
> |  Maybe haddock is compiling the base libraries without -O...  but somehow still looking
> |  at the SPECiALISE pragmas....
> |  
> |  Yes that's it!   Without -O we should ignore SPECIALISE pragmas rather than complain
> |  that the exporting module doesn't have an INLINABLE pragma (it does, but the
> |  exporting module was compiled without -O).  Aha.  Patch coming
> |  
> |  S
> |  
> |  _______________________________________________
> |  Cvs-libraries mailing list
> |  Cvs-libraries at haskell.org
> |  http://www.haskell.org/mailman/listinfo/cvs-libraries
>