patch applied (packages/Win32): Move -DUNICODE from cc-options into HsWin32.h, where it can do less damange

[Simon Marlow]

Ian Lynagh wrote:
> On Thu, Aug 21, 2008 at 04:41:03AM -0700, Simon Marlow wrote:
>> Wed Aug 20 07:00:27 PDT 2008  Simon Marlow <marlowsd at gmail.com>
>>   * Move -DUNICODE from cc-options into HsWin32.h, where it can do less damange
>>   The problem is that cc-options get added to the command line for any C
>>   compilation in a package that depends (directly or indirectly) on
>>   Win32, and -DUNICODE was having unexpected effects.
> 
> I don't know if it is related to this patch or just a coincidence, but
> the Windows builder here:
> http://darcs.haskell.org/buildbot/all/builders/x86%20Windows%20head%20fast/builds/2608/steps/runtestsuite/logs/unexpected
> is giving messages like:
>     user error (CreateDirectory: Cno raeafl hnta iearayeit. (error code: b7))
> 
> It's trying to say:
>     Cannot create a file when that file already exists
>     C n o   r a e a f l   h n t a   i e a r a y e i t
> so it looks like a UTF 16 error is being printed with low-8-bits IO
> functions.
> 
> I can't reproduce it here; I get the correct error printed
> (Windows/msys).

Ok, I'm validating fixes for the Win32/directory problems on the HEAD right 
now, should be fixed later today.  As a side-effect I've made the Win32 
library generate proper IOExceptions, which is a nice improvement.

Cheers,
	Simon