cvs commit: fptools/libraries/base/Data Set.hs

Malcolm Wallace Malcolm.Wallace at cs.york.ac.uk
Thu Sep 29 04:54:37 EDT 2005


Ross Paterson <ross at soi.city.ac.uk> writes:

> >     libraries/base/Data  Set.hs 
> >   Log:
> >   Add an instance of Read to correspond to the existing Show instance.
> >   (Implementation based on H'98 Report definition of 'readList'.)
> 
> Shouldn't that be reads rather than readsPrec i on the RHS, and the
> whole wrapped in readParen False?

I'm not sure about the precedence thing, so yes perhaps it should be
'reads'.  I don't think it needs a readParen though?  The curly braces
already delimit the extent of the value, and since the instance of Show
does not introduce parens, I didn't see any need to parse them back in.

If I've missed some subtlety, do just go ahead and fix it.

Regards,
    Malcolm


More information about the Cvs-libraries mailing list