make check on Windows (MSYS), with patch

Brian Smith brianlsmith at gmail.com
Fri Jul 29 19:17:59 EDT 2005


Ross wrote:
>Brian wrote:
>> I have attached a patch that allows "make check" run more or less
>> successfully on Windows. The patch converts Windows-style newlines to
>> Unix-style newlines from the output of the test, so that when the
>> actual output is compared to the expected output, the newline
>> differences don't set off false positives. It also fixes a couple
>> obvious problems with the tests to make them work on MSYS.
>
> Thanks!  I don't know how to strip CRs portably, but I've applied
> the rest.

What do you mean by "portably?" Do you mean, you want it to work for
non-GNU sed, or do you just mean that you want it to work on
non-Windows systems? My goal in writing it was to have it work on all
systems, even Unix and Linux where it is superfluous.

I hardly know anything about sed; I just copied it out of one of the
sed FAQS. But, I see no reason why it shouldn't work for any system
with GNU sed. For non-GNU sed, maybe "sed 's/\r//" or "tr '\013' ''"
or dos2unix will work instead?

Anyway, the other parts of the patch are not useful without the
newline patch because the newline problem causes every test to fail.

- Brian


More information about the Cvs-hugs mailing list