Issues, issues, issues...
Bardur Arantsson
spam at scientician.net
Thu Jun 25 17:00:15 UTC 2015
On 06/25/2015 06:54 PM, John Alfred Nathanael Chee wrote:
> On Thu, Jun 25, 2015 at 8:55 AM, Bardur Arantsson <spam at scientician.net>
> wrote:
>
>> Do people
>> spontaneously clean up TODOs that others have left behind?
>>
>
> There's been a case where a TODO was nullified by resolving an issue on
> Github, in that case I deleted the TODO.
>
Good on you!
> If you understand the code well enough to understand the request in the
> TODO, I'd suggest fixing it and submitting a pull request.
>
Certainly! In fact I was very tempted by one earlier today, but I
realized that it would require a lot of refactoring of functions with
~5-10 parameters... and so I didn't bother since that's not what I was
there to fix. I'm guessing a lot of people have been in a similar situation.
My point is mostly to do with visibility: Either it isn't serious (in
which case it shouldn't be there), or it should be addressed (in which
case it should be an Issue.)
Regards,
More information about the cabal-devel
mailing list