[PATCH] (haskeline) Include termios.h on android

Ian Lynagh ian at well-typed.com
Sun Feb 17 17:28:35 CET 2013

On Sun, Feb 17, 2013 at 05:01:45PM +0100, Nathan Hüsken wrote:
> On 02/17/2013 01:42 PM, Ian Lynagh wrote:
> >
> >>-#ifdef USE_TERMIOS_H
> >>+#if defined(USE_TERMIOS_H) || defined(__ANDROID__)
> >It looks like this would be better handled by defining USE_TERMIOS_H in
> >the .cabal file if the os is android.
> >
> I agree, but I was unable to detect in tharget os in cabal when
> cross compiling.

Ah, that should be fixed then. It shouldn't be too hard: the
"ghc --info" output already includes e.g.
 ,("target os","OSLinux")
and I'm pretty sure that Cabal already parses the --info output, so it
should just be a case of using that value when evaluating the
os(android) conditional.

Ah, hmm, except OSLinux is a constructor of a type that is in the ghc
package. Cabal has slightly different types in Distribution.System.
Should we make a shared type, possibly in a new 'platform' package?


More information about the cabal-devel mailing list