patch applied (hackage-server): "Audit for UTF8 safety (and remove json)"

devnull at community.haskell.org devnull at community.haskell.org
Tue Aug 13 14:39:07 CEST 2013


Tue Aug 13 12:19:07 BST 2013  edsko at well-typed.com
  * Audit for UTF8 safety (and remove json)
  Ignore-this: 5731a4833f3fae0ed329f7794672759
  
  This is a longish commit which removes a lot of uses of Data.ByteString.Char8
  and Data.ByteString.Lazy.Char8 in favour of UTF8 safe functions. There are a
  few (hopefully legiminate) uses of D.B.*.Char8 left, most notably in
  Client.ParseApacheLogs and Client.UserAddressesDb, and a few small uses in
  other modules, marked with why they are ok. A handful of modules are not yet
  checked or changed; they have been marked as TODO. 
  
  Also removed a bunch of compiler warnings in the process.

    M ./BuildClient.hs -5 +5
    M ./Distribution/Client.hs -5 +15
    A ./Distribution/Client/ParseApacheLogs.hs
    M ./Distribution/Client/PkgIndex.hs -1 +1
    M ./Distribution/Client/UserAddressesDb.hs -2 +2
    M ./Distribution/Server/Features/BuildReports.hs -1 +1
    M ./Distribution/Server/Features/BuildReports/Backup.hs -1 +1
    M ./Distribution/Server/Features/BuildReports/BuildReports.hs -1 +2
    M ./Distribution/Server/Features/Core.hs -1 +1
    M ./Distribution/Server/Features/Distro.hs -4 +2
    M ./Distribution/Server/Features/Documentation.hs -6 +6
    M ./Distribution/Server/Features/DownloadCount.hs -14 +13
    M ./Distribution/Server/Features/EditCabalFiles.hs -3 +4
    M ./Distribution/Server/Features/Html.hs -1
    M ./Distribution/Server/Features/LegacyPasswds.hs -2 +4
    M ./Distribution/Server/Features/LegacyPasswds/Auth.hs -1 +2
    M ./Distribution/Server/Features/PreferredVersions.hs -24 +36
    M ./Distribution/Server/Features/ServerIntrospect.hs -18 +34
    M ./Distribution/Server/Features/Upload.hs -1 +1
    M ./Distribution/Server/Features/UserSignup.hs -1 +1
    M ./Distribution/Server/Features/Users.hs -9 +23
    M ./Distribution/Server/Framework/Auth.hs -2 +2
    M ./Distribution/Server/Framework/AuthCrypt.hs -1 +1
    M ./Distribution/Server/Framework/BackupRestore.hs -2 +2
    M ./Distribution/Server/Framework/Error.hs -2 +3
    M ./Distribution/Server/Framework/Logging.hs -1 +1
    M ./Distribution/Server/Framework/RequestContentTypes.hs -14 +8
    M ./Distribution/Server/Framework/Resource.hs -1 +1
    M ./Distribution/Server/Framework/ResponseContentTypes.hs -26 +19
    M ./Distribution/Server/Framework/Templating.hs -4 +5
    M ./Distribution/Server/Packages/Unpack.hs -2 +2
    M ./Distribution/Server/Util/GZip.hs -9 +8
    M ./Distribution/Server/Util/Parse.hs -11 +5
    M ./Distribution/Server/Util/TextSearch.hs -2 +2
    M ./ImportClient.hs -175 +94
    M ./MirrorClient.hs -7 +18
    M ./hackage-server.cabal -4 +4





More information about the cabal-devel mailing list