patch applied (hackage-server): "Fix the 'restore' process"

devnull at devnull at
Mon Nov 26 15:33:08 CET 2012

Mon Nov 26 14:30:48 GMT 2012  Edsko de Vries <edsko at>
  * Fix the 'restore' process
  Ignore-this: 5199ad4a1f430bd4c338f42054ecd0b2
  - Not all features implemented 'restore' after the refactoring, causing 
    restore to fail
  - 'importTar' assumed a single RestoreBackup per feature, while we now have
    multiple (though, thankfully, they implemented Monoid)
  Note that 'testRoundtrip' is still broken, but it turns out it was already
  broken even before the refactoring. The problem is that testRoundtripByQuery
  returns a check which compares the state of the database using the AcidState
  handle which corresponds to the *initial database* (before the export and
  reimport), and hence is comparing a database to itself and always returns
  success. It should instead use the handle created after the re-import, but that
  handle is not yet available when 'testRoundtrip' is called, so this requires
  some re-engineering of how tests are set up. Will fix this separately.

    M ./Distribution/Server.hs -6 +11
    M ./Distribution/Server/Features/Check.hs +1
    M ./Distribution/Server/Features/HaskellPlatform.hs -5 +6
    M ./Distribution/Server/Features/PreferredVersions.hs +1
    M ./Distribution/Server/Framework/BackupRestore.hs +1
    M ./Main.hs -2 +4

More information about the cabal-devel mailing list