[Haskell-beginners] Critique my program
dpfrey at shaw.ca
Sun Jan 10 19:12:59 EST 2010
I have received a couple of responses off list so far.
One came from Erlend Hamberg. He suggested that I run hlint as a first step.
The other response came from Daniel Fischer. He provided more concise
versions of some of the functions that I wrote.
I have made changes based on both responses and committed it to
Thanks for the suggestions.
On January 10, 2010 11:44:38 am David Frey wrote:
> A couple of months ago, I was tutoring my cousin in an introductory
> computer science class. We talked about his assignment in which he had to
> implement a subset of the Battleship board game using Java.
> I decided it would be fun for me to try to complete the assignment in
> Haskell. I forgot about the project for a while, but I picked it up and
> finished it today.
> I have put the code on BitBucket (a Mercurial based code hosting site for
> those who don't know) at this location:
> I am hoping that some people from this list could review my code. I'm not
> very concerned with correctness. I'm more interested in how my code can be
> clarified through use of existing functions or standard Haskell idioms.
> If you don't have Mercurial installed or don't want to clone the
> repository, you can browse the source here:
> The original PDF from my cousin's assignment can be viewed here:
> Feel free to submit your comments in any format. Patches, written
> comments, complete re-writes of the program, etc. are all welcome.
> David Frey
More information about the Beginners