<div dir="ltr">Applied. Thanks Norbert<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Mar 15, 2015 at 9:11 AM, Norbert Zeh <span dir="ltr"><<a href="mailto:nzeh@cs.dal.ca" target="_blank">nzeh@cs.dal.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for the pointers, Adam.  Updated patch is attached.<br><br>Cheers,<div>Norbert</div><div><div class="h5"><br><div class="gmail_quote">On Sat, Mar 14, 2015 at 8:18 PM adam vogt <<a href="mailto:vogt.adam@gmail.com" target="_blank">vogt.adam@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Norbert,<br><br>Would you be willing to change the license to the one contrib uses? Otherwise I suppose you should to submit the module to this (unaffiliated) project: <a href="https://hackage.haskell.org/package/xmonad-contrib-gpl" target="_blank">https://hackage.haskell.org/package/xmonad-contrib-gpl</a><br><br>Also, there's a XMonad.Util.Types.Direction2D that also defines L R U D constructors. It would be better to import and use that one instead of data Direction.<br><br>Thanks,<br>Adam<br><br></div><div class="gmail_extra"><br><div class="gmail_quote"></div></div><div class="gmail_extra"><div class="gmail_quote">On Sat, Mar 14, 2015 at 11:54 AM, Norbert Zeh <span dir="ltr"><<a href="mailto:nzeh@cs.dal.ca" target="_blank">nzeh@cs.dal.ca</a>></span> wrote:<br></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span>On Tue, Mar 3, 2015 at 3:39 PM Norbert Zeh <<a href="mailto:nzeh@cs.dal.ca" target="_blank">nzeh@cs.dal.ca</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Dec 15, 2014 at 11:50 AM, Brandon Allbery <span dir="ltr"><<a href="mailto:allbery.b@gmail.com" target="_blank">allbery.b@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Fri, Dec 12, 2014 at 12:10 PM, Norbert Zeh <span dir="ltr"><<a href="mailto:nzeh@cs.dal.ca" target="_blank">nzeh@cs.dal.ca</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">... and thought I'd share.  Patch is attached.<br></div></blockquote><div><br></div></span><div>A few nits:</div><div><br></div><div>- the comment in XMonad.Layout.Dwindle identifies it as XMonad.Layout.Spiral</div><div><br></div><div>- consider renaming Rotation, as anyone using your module must also import XMonad hiding (Rotation). At the very least, you should document the requirement if you're going to keep it, since you export it. Possible alternate name: Chirality.</div></div></div></div></blockquote></div></div></div></blockquote><div><br></div></span><div>Updated patch is attached.  Let me know if anything else needs to be fixed.</div><div><br></div><div>Cheers,</div><div>Norbert </div></div></div>
<br></blockquote></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">_______________________________________________<br>
xmonad mailing list<br>
<a href="mailto:xmonad@haskell.org" target="_blank">xmonad@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad</a><br>
<br></blockquote></div><br></div>
</blockquote></div></div></div></div>
<br>_______________________________________________<br>
xmonad mailing list<br>
<a href="mailto:xmonad@haskell.org">xmonad@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad</a><br>
<br></blockquote></div><br></div>