[xmonad] darcs patch: Config.hs, Operations.hs: +unfloat, unfloatFocused fun...

Don Stewart dons at galois.com
Sun May 3 15:54:34 EDT 2009


gwern0:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> On Sat, May 2, 2009 at 3:54 PM, Don Stewart  wrote:
> > They're in the default Config -- i.e. that binding is already in scope.
> >
> > So people are intentionally duplicating parts of the default config for
> > some reason.
> >
> > I think this is quite different to the case where there is a spontaneous
> > idiom appearing.
> >
> > -- Don
> 
> You refer to just the ones duplicating the mod-t binding? I'd say it's
> an interesting example of how our keybinding system is suboptimal -
> even moderately competent users should not find themselves duplicating
> stuff like this.
> 
> But anyway, even if you filter out the ones binding to xK_t, there're
> still 10 configs using this same function definition.
> 
> Is that not enough? Before I invest anymore time in trying to make
> configs more concise & usable by factoring out commonalities, I'd
> appreciate some hard guidelines on when something is meritorious
> enough to be put in core and when it is not.
> 

One function composition probably isn't worthwhile.  Using incompatible
names also isn't a good idea (naming is a bikeshed, beware!)

Look for larger patterns : particular sets of modules used together, for
example.

-- Don


More information about the xmonad mailing list