<div dir="ltr">><span style="font-size:12.8px"> keep the function until the next larger API overhaul or say, for five years or a decade.</span><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">That sounds good to me, I wasn't sure how long is reasonable to wait after deprecating an API before removing it.</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 24, 2018 at 6:25 AM, Andreas Abel <span dir="ltr"><<a href="mailto:andreas.abel@ifi.lmu.de" target="_blank">andreas.abel@ifi.lmu.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> I'd say 1 year is too short. There is no need to remove the function<br>
> quickly. I'd vote for adding a deprecation warning soon, but then keep<br>
> the function until the next larger API overhaul or say, for five years<br>
> or a decade.<br>
<br></span>
+1.<br>
<br>
Yes.<div><div class="h5"><br>
<br>
On 24.01.2018 08:11, Henning Thielemann wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<br>
On Tue, 23 Jan 2018, Matt Renaud wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cons:<br>
-----<br>
<br>
- API change requires users to update their code<br>
+ unordered-containers has A LOT of users: 358815 total (13325 in the last 30 days)<br>
</blockquote>
<br>
A better measure are certainly the reverse package dependencies:<br>
<a href="https://www.stackage.org/package/unordered-containers" rel="noreferrer" target="_blank">https://www.stackage.org/packa<wbr>ge/unordered-containers</a><br>
<br>
There are almost 1000 packages that import unordered-containers, still quite a lot!<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Migration - Option 1:<br>
---------------------<br>
<br>
- Announce on Haskell communication channels (haskell-cafe@, haskell-community@, #haskell on Twitter, Reddit<br>
thread, etc.)<br>
- Users of unordered-containers >= 0.2.9.0 receive warning about deprecated function<br>
- Code can be updated by find and replace: s/lookupDefault/findWithDefaul<wbr>t/<br>
- lookupDefault with deprecation notice remains for 1 year (subject to change)<br>
- after 1 year the lookupDefault function is removed, unordered-containers version bumped to 0.3.0.0 (major<br>
version bump due to breaking change)<br>
</blockquote>
<br>
I'd say 1 year is too short. There is no need to remove the function quickly. I'd vote for adding a deprecation warning soon, but then keep the function until the next larger API overhaul or say, for five years or a decade.<br>
<br>
<br></div></div>
______________________________<wbr>_________________<br>
Libraries mailing list<br>
<a href="mailto:Libraries@haskell.org" target="_blank">Libraries@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/libraries" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bi<wbr>n/mailman/listinfo/libraries</a><br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<br>
-- <br>
Andreas Abel <>< Du bist der geliebte Mensch.<br>
<br>
Department of Computer Science and Engineering<br>
Chalmers and Gothenburg University, Sweden<br>
<br>
<a href="mailto:andreas.abel@gu.se" target="_blank">andreas.abel@gu.se</a><br>
<a href="http://www.cse.chalmers.se/~abela/" rel="noreferrer" target="_blank">http://www.cse.chalmers.se/~ab<wbr>ela/</a><br>
</font></span></blockquote></div><br></div>