[Haskell-cafe] Who can send a patche to vim project?

Takenobu Tani takenobu.hs at gmail.com
Mon Dec 11 12:16:25 UTC 2017


Hi cafe,

Who can send a patche to vim project?

I'd like to update vim syntax file (haskell.vim) to fix numeric literals.
I read the vim `CONTRIBUTING.md` file [1].
It instructs me to contact the maintainer of each files.
In the header of `haskell.vim`, the maintainor of `haskell.vim` is
haskell-cafe at ML. [2]
Who is the maintainer of `haskell.vim`?

I'd like to make fix on numeric literals extension: [3]
  * BinaryLiterals
  * HexFloatLiterals
  * NumericUnderscores

I prepared two kinds of patches.
  * Exact pattern version [4]
  * Fast (but approximate) pattern version [5]

I visually checked patches with the these files [6][7].

Could you send a patch of [4] or [5] to vim project?


P.S.
I have already sent patches to two projects.

  * `language-haskell` for atom and linguist [8]
      You can already use it on atom.
      Linghist (which is used from github) will apply it soon.

  * `pygments` [9]
      It is pending review.


[1]:
https://github.com/vim/vim/blob/master/CONTRIBUTING.md#syntax-indent-and-other-runtime-files
[2]: https://github.com/vim/vim/blob/master/runtime/syntax/haskell.vim#L3
[3]:
https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0009-numeric-underscores.rst#new-syntax-this-proposal
[4]:
https://github.com/vim/vim/compare/master...takenobu-hs:syntax-haskell-literal-exact
[5]:
https://github.com/vim/vim/compare/master...takenobu-hs:syntax-haskell-literal-fast

[6]:
https://github.com/takenobu-hs/ghc/blob/squashed-numeric-underscores/testsuite/tests/parser/should_run/NumericUnderscores0.hs
[7]:
https://github.com/takenobu-hs/ghc/blob/squashed-numeric-underscores/testsuite/tests/parser/should_run/NumericUnderscores1.hs

[8]:
https://github.com/atom-haskell/language-haskell/commit/f90eb7d8662493536f54898e52b4c7b1dc96de41
[9]:
https://bitbucket.org/birkenfeld/pygments-main/issues/1399/update-haskell-with-lexer-for-numeric

Regards,
Takenobu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/haskell-cafe/attachments/20171211/865ff7bf/attachment.html>


More information about the Haskell-Cafe mailing list