[GHC] #16376: GHCi HEAD silently accepts ill-kinded visible type applications with :type

GHC ghc-devs at haskell.org
Sat Mar 9 07:08:28 UTC 2019


#16376: GHCi HEAD silently accepts ill-kinded visible type applications with :type
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  highest           |            Milestone:  8.10.1
       Component:  GHCi              |              Version:  8.9
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  GHC accepts       |            Test Case:
  invalid program                    |  ghci/scripts/T16376
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Marge Bot <ben+marge-bot@…>):

 In [changeset:"5be7ad7861c8d39f60b7101fd8d8e816ff50353a/ghc"
 5be7ad78/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5be7ad7861c8d39f60b7101fd8d8e816ff50353a"
 Use captureTopConstraints in TcRnDriver calls

 Trac #16376 showed the danger of failing to report an error
 that exists only in the unsolved constraints, if an exception
 is raised (via failM).

 Well, the commit 5c1f268e (Fail fast in solveLocalEqualities)
 did just that -- i.e. it found errors in the constraints, and
 called failM to avoid a misleading cascade.

 So we need to be sure to call captureTopConstraints to report
 those insolubles.  This was wrong in TcRnDriver.tcRnExpr and
 in TcRnDriver.tcRnType.

 As a result the error messages from test T13466 improved slightly,
 a happy outcome.
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16376#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list