[GHC] #15302: TTG for IPBind wrong extension name

[GHC]

#15302: TTG for IPBind wrong extension name
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  ttg
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"5f06cf6b6199c8f0e4921f4126f6eb15e2ff18ac/ghc" 5f06cf6/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5f06cf6b6199c8f0e4921f4126f6eb15e2ff18ac"
 TTG for IPBind had wrong extension name

 The standard[1] for extension naming is to use the XC prefix for the
 internal extension points, rather than for a new constructor.

 This is violated for IPBind, having

     data IPBind id
       = IPBind
             (XIPBind id)
             (Either (Located HsIPName) (IdP id))
             (LHsExpr id)
       | XCIPBind (XXIPBind id)

 Swap the usage of XIPBind and XCIPBind

 [1]
 https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow#Namingconventions

 Closes #15302
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15302#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler