[GHC] #15302: TTG for IPBind wrong extension name

GHC ghc-devs at haskell.org
Fri Jun 22 15:17:14 UTC 2018


#15302: TTG for IPBind wrong extension name
-------------------------------------+-------------------------------------
           Reporter:  alanz          |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:  8.6.1
          Component:  Compiler       |           Version:  8.4.3
           Keywords:  ttg            |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 The standard[1] for extension naming is to use the `XC` prefix for the
 internal extension points, rather than for a new constructor.

 This is violated for `IPBind`, having

 {{{#!hs
 data IPBind id
   = IPBind
         (XIPBind id)
         (Either (Located HsIPName) (IdP id))
         (LHsExpr id)
   | XCIPBind (XXIPBind id)
 }}}

 Swap the usage of `XIPBind` and `XCIPBind`

 [1]
 https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow#Namingconventions

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15302>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list