[GHC] #15904: hp2ps fail with parse error when the command args contains double quotes

GHC ghc-devs at haskell.org
Tue Dec 11 23:21:06 UTC 2018


#15904: hp2ps fail with parse error when the command args contains double quotes
-------------------------------------+-------------------------------------
        Reporter:  watashi           |                Owner:  watashi
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Profiling         |              Version:  8.7
      Resolution:  fixed             |             Keywords:  hp2ps
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D5346
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"0136906c9e69b02cd1ffe2704fa5d737d8c4cfaf/ghc" 0136906/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="0136906c9e69b02cd1ffe2704fa5d737d8c4cfaf"
 Fix uninformative hp2ps error when the cmdline contains double quotes

 Reapply D5346 with fix incompatible shell quoting in tests. It seems
 like `$'string'` is not recognized under all test environments, so let's
 avoid it in tests.

 Test Plan:
 ```
 hp2ps: "T15904".hp, line 2: integer must follow identifier
 ```

 use new ghc and hp2ps to profile a simple program.

 Reviewers: simonmar, bgamari, erikd, tdammers

 Reviewed By: bgamari

 Subscribers: tdammers, carter, rwbarton

 GHC Trac Issues: #15904

 Differential Revision: https://phabricator.haskell.org/D5388
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15904#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list