[GHC] #15894: Cannot find symbol during interactive linking using new-repl on Windows

GHC ghc-devs at haskell.org
Tue Dec 4 07:15:52 UTC 2018


#15894: Cannot find symbol during interactive linking using new-repl on Windows
-----------------------------+----------------------------------------
        Reporter:  YellPika  |                Owner:  (none)
            Type:  bug       |               Status:  patch
        Priority:  normal    |            Milestone:  8.6.3
       Component:  Compiler  |              Version:  8.6.2
      Resolution:            |             Keywords:
Operating System:  Windows   |         Architecture:  Unknown/Multiple
 Type of failure:  Other     |            Test Case:  T15894
      Blocked By:            |             Blocking:
 Related Tickets:            |  Differential Rev(s):  Phab:D5353
       Wiki Page:            |
-----------------------------+----------------------------------------

Comment (by Tamar Christina <tamar@…>):

 In [changeset:"a8b7cef4d45a5003bf7584e06912f0f632116c71/ghc"
 a8b7cef4/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="a8b7cef4d45a5003bf7584e06912f0f632116c71"
 linker: store entire link map and use it.

 Summary:
 This fixes a corner case in which we have seen the symbol multiple times
 in
 different static libraries, but due to a depencency we end up loading the
 symbol from a library other than the first one.

 Previously the runtime linker would only track symbols from the first
 library and did not store the full link map.  In this case it was unable
 to find the address for the symbols in the second library during delay
 loading.

 This change stores the address of all symbols seen so a full link map
 is generated, such that when we make a different decision later than what
 was expected we're able to still correctly load the library.

 Test Plan: ./validate, new testcase T15894

 Reviewers: angerman, bgamari, erikd, simonmar

 Reviewed By: bgamari

 Subscribers: rwbarton, carter

 GHC Trac Issues: #15894

 Differential Revision: https://phabricator.haskell.org/D5353
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15894#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list