[GHC] #15971: Hadrian fails Shake's linter on Windows

GHC ghc-devs at haskell.org
Mon Dec 3 13:42:51 UTC 2018


#15971: Hadrian fails Shake's linter on Windows
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.7
  (Hadrian)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Simon Peyton Jones <simonpj@…>):

 In [changeset:"03d4852658e1b7407abb4da84b1b03bfa6f6db3b/ghc"
 03d48526/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="03d4852658e1b7407abb4da84b1b03bfa6f6db3b"
 Introduce tcTypeKind, and use it

 In the type checker Constraint and * are distinct; and the function
 that takes the kind of a type should respect that distinction
 (Trac #15971).

 This patch implements the change:

 * Introduce Type.tcTypeKind, and use it throughout the type
   inference engine

 * Add new Note [Kinding rules for types] for the kinding
   rules, especially for foralls.

 * Redefine
     isPredTy ty = tcIsConstraintKind (tcTypeKind ty)
   (it had a much more complicated definition before)

 Some miscellaneous refactoring

 * Get rid of TyCoRep.isTYPE, Kind.isTYPEApp,
   in favour of TyCoRep.kindRep, kindRep_maybe

 * Rename Type.getRuntimeRepFromKind_maybe
   to getRuntimeRep_maybe

 I did some spot-checks on compiler perf, and it really doesn't
 budge (as expected).
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15971#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list