[GHC] #10412: isAlphaNum includes mark characters, but neither isAlpha nor isNumber do

GHC ghc-devs at haskell.org
Fri Apr 20 03:00:47 UTC 2018


#10412: isAlphaNum includes mark characters, but neither isAlpha nor isNumber do
-------------------------------------+-------------------------------------
        Reporter:  Artyom.Kazak      |                Owner:  Azel
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  libraries/base    |              Version:  7.10.1
      Resolution:                    |             Keywords:  unicode,
                                     |  newcomer
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4593
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"a26983a3aef25b3fa5f66b4d68ea7240a6dd1543/ghc"
 a26983a3/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="a26983a3aef25b3fa5f66b4d68ea7240a6dd1543"
 Fixes isAlphaNum re. isAlpha/isNumber and doc fix (trac issue #10412)

 Corrects the inconsistency between Data.Char.isAlphaNum,
 Data.Char.isAlpha and Data.Char.isNumber. Indeed, isAlphaNum was
 returning True not only when isAlpha or isNumber returned True but
 also when isMark did. The selectors for the Mn, Mc and Me general
 categories where removed from the macro generating u_iswalnum in
 ubconfc.

 Also, Data.Char.isAlphaNum's documentation was changed to state that
 isAlphaNum returns true not only for Unicode number digits but for
 Unicode numbers in general in Unicode.hs.

 Signed-off-by: ARJANEN Loïc Jean David <arjanen.loic at gmail.com>

 Reviewers: hvr, ekmett, lelf, bgamari

 Reviewed By: bgamari

 Subscribers: thomie, carter

 GHC Trac Issues: #10412

 Differential Revision: https://phabricator.haskell.org/D4593
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10412#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list