[GHC] #15047: Outdated comments in RnSource.hs

GHC ghc-devs at haskell.org
Tue Apr 17 12:15:52 UTC 2018


#15047: Outdated comments in RnSource.hs
-------------------------------------+-------------------------------------
           Reporter:  ulysses4ever   |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:  8.6.1
          Component:  Compiler       |           Version:  8.2.2
  (Type checker)                     |
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):  Phab:D4596     |         Wiki Page:
-------------------------------------+-------------------------------------
 While reading sources of the Renamer I noticed some comments which seem to
 be irrelevant now.

 The body of `rnSrcDecls` (`RnSource.hs`) is broken up in several “parts”
 (A, B, etc.). #b1884b0e6 removed what is used to be called part (C) — the
 use of `extendRecordFieldEnv`, with the following comment in Phab:D761:

 > Get rid of `extendRecordFieldEnv`, do it in `getLocalNonValBinders`
 instead

 (Note: `getLocalNonValBinders` belongs to part (B)). At the same time, the
 references to this part (C) remained in comments to other "parts" (B and
 D2). Removing these references will save inexperienced reader from
 confusion.

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15047>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list