[GHC] #13940: Reduce duplicate implementations of argument handling on Windows

GHC ghc-devs at haskell.org
Thu Jul 27 20:18:28 UTC 2017


#13940: Reduce duplicate implementations of argument handling on Windows
-------------------------------------+-------------------------------------
        Reporter:  AndreasK          |                Owner:  AndreasK
            Type:  task              |               Status:  new
        Priority:  low               |            Milestone:
       Component:  Runtime System    |              Version:
      Resolution:                    |             Keywords:  unicode
                                     |  windows
Operating System:  Windows           |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:  #12870            |  Differential Rev(s):  Phab:D3739
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Tamar Christina <tamar@…>):

 In [changeset:"7af0b906116e13fbd90f43f2f6c6b826df2dca77/ghc"
 7af0b906/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="7af0b906116e13fbd90f43f2f6c6b826df2dca77"
 Initialize hs_init with UTF8 encoded arguments on Windows.

 Summary:
 Get utf8 encoded arguments before we call hs_init and use them
 instead of ignoring hs_init arguments. This reduces differing
 behaviour of the RTS between windows and linux and simplifies
 the code involved.

 A few testcases were changed to expect the same result on windows
 as on linux after the changes.

 This fixes #13940.

 Test Plan: ./validate

 Reviewers: austin, hvr, bgamari, erikd, simonmar, Phyx

 Subscribers: Phyx, rwbarton, thomie

 GHC Trac Issues: #13940

 Differential Revision: https://phabricator.haskell.org/D3739
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13940#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list