[GHC] #13301: GHC base directory assumptions

GHC ghc-devs at haskell.org
Fri Feb 24 00:06:04 UTC 2017


#13301: GHC base directory assumptions
---------------------------------+----------------------------------------
        Reporter:  Phyx-         |                Owner:  Phyx-
            Type:  bug           |               Status:  patch
        Priority:  normal        |            Milestone:  8.4.1
       Component:  Compiler      |              Version:  8.0.2
      Resolution:                |             Keywords:
Operating System:  Windows       |         Architecture:  Unknown/Multiple
 Type of failure:  None/Unknown  |            Test Case:
      Blocked By:                |             Blocking:
 Related Tickets:                |  Differential Rev(s):  Phab:D3158
       Wiki Page:                |
---------------------------------+----------------------------------------

Comment (by bgamari):

 Oops, the commit mentioned the wrong ticket,

 In [changeset:"8d64395b43cb73d110767cab512a368b3db018de/ghc" 8d64395/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="8d64395b43cb73d110767cab512a368b3db018de"
 Correct Windows libdir assumptions.

 GHC and ghc-pkg make some pretty hard assumptions about where they're
 running on Windows. They assume that they are always running from
 `foo/bin/ghc.exe` and that to find the `lib` folder they can drop
 `bin/ghc.exe` from the base path and append `lib`.

 This is already false for the testsuite, which when testing thenbindist
  has one test which puts the binaries in `inplace/test   spaces`.

 For some reason before this was either being skipped or mysteriously
 passing.
 But as of `2017.02.11` our luck ran out.

 the testsuite triggers a failure such as those in #13310

 Let's soften the assumption and just check that `../lib` exists instead.

 80 chars

 Test Plan: ./validate

 Reviewers: austin, erikd, bgamari

 Reviewed By: bgamari

 Subscribers: thomie, #ghc_windows_task_force

 Differential Revision: https://phabricator.haskell.org/D3158
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13301#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list