[GHC] #12636: ProfHeap's printf modifiers are incorrect

GHC ghc-devs at haskell.org
Tue Feb 14 21:52:29 UTC 2017


#12636: ProfHeap's printf modifiers are incorrect
-------------------------------------+-------------------------------------
        Reporter:  Phyx-             |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.2.1
       Component:  Runtime System    |              Version:  8.0.1
      Resolution:                    |             Keywords:  newcomer
Operating System:  Windows           |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D3129
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Phyx-):

 It may be that it isn't a problem. In case it is, we should add an assert
 before `censuses[era].void_total -= size;`.

 `assert (censuses[era].void_total >= size);` at least this way, if it is a
 problem we'll trigger it. if it's not it also makes it clear to the next
 person that we've thought about it and it's not an issue.

 if it turns out to be a problem, then we should replace `ssize_t` with a
 normal signed type like `uint64_t` or something.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12636#comment:10>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list