[GHC] #11328: Auto complete in ghci shows $sel:function:Type for DuplicateRecordFields fields

GHC ghc-devs at haskell.org
Mon Feb 1 21:11:26 UTC 2016


#11328: Auto complete in ghci shows $sel:function:Type for DuplicateRecordFields
fields
-------------------------------------+-------------------------------------
        Reporter:  kolmodin          |                Owner:  adamgundry
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.0.1
       Component:  GHCi              |              Version:  8.0.1-rc1
      Resolution:                    |             Keywords:
                                     |  DuplicateRecordFields, ORF
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
                                     |  ghci/should_run/T11328
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D1870
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"dd0b7c78f64f2498594d3ef89d3bf884402f14d9/ghc" dd0b7c7/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="dd0b7c78f64f2498594d3ef89d3bf884402f14d9"
 Avoid mangled/derived names in GHCi autocomplete (fixes #11328)

 This changes `getRdrNamesInScope` to use field labels rather than
 selector names for fields from modules with `DuplicateRecordFields`
 enabled. Moreover, it filters out derived names (e.g. type
 representation bindings) that shouldn't show up in autocomplete.

 Test Plan: New test ghci/should_run/T11328

 Reviewers: kolmodin, austin, bgamari, simonpj

 Reviewed By: bgamari, simonpj

 Subscribers: simonpj, thomie

 Differential Revision: https://phabricator.haskell.org/D1870

 GHC Trac Issues: #11328
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11328#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list