[GHC] #10667: '-g' option generates invalid assembly when '*/*' operator is used

GHC ghc-devs at haskell.org
Thu Oct 29 23:04:31 UTC 2015


#10667: '-g' option generates invalid assembly when '*/*' operator is used
-------------------------------------+-------------------------------------
        Reporter:  slyfox            |                Owner:
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  7.10.3
       Component:  Compiler          |              Version:  7.10.2-rc2
  (CodeGen)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:  x86_64
 Type of failure:  Compile-time      |  (amd64)
  crash                              |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D1386
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Sergei Trofimovich <siarheit@…>):

 In [changeset:"e272ab99f60884e5c510c9597fbdb1a570eedcaa/ghc" e272ab9/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="e272ab99f60884e5c510c9597fbdb1a570eedcaa"
 x86 codegen: don't generate location comments

 The following source snippet 'module A where x */* y = 42'
 when being compiled with '-g' option emits syntactically
 invalid comment for GNU as:

     .text
         .align 8
         .loc 1 3 1 /* */* */

 Fixed by not emitting comments at all. We already suppress
 all asm comments in 'X86/Ppr.hs'.

 Signed-off-by: Sergei Trofimovich <siarheit at google.com>

 Test Plan: added test and check it works

 Reviewers: scpmw, simonmar, austin, bgamari

 Reviewed By: simonmar

 Subscribers: thomie

 Differential Revision: https://phabricator.haskell.org/D1386

 GHC Trac Issues: #10667
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10667#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list