[GHC] #10449: Out-of-tree tests broken on MinGW + native Python due to quoting of config.compiler

GHC ghc-devs at haskell.org
Wed May 27 07:03:54 UTC 2015


#10449: Out-of-tree tests broken on MinGW + native Python due to quoting of
config.compiler
-------------------------------+-------------------------------------------
        Reporter:  Rufflewind  |                   Owner:
            Type:  bug         |                  Status:  new
        Priority:  normal      |               Milestone:
       Component:  Test Suite  |                 Version:  7.10.1
      Resolution:              |                Keywords:
Operating System:  Windows     |            Architecture:  Unknown/Multiple
 Type of failure:  Other       |               Test Case:
      Blocked By:              |                Blocking:
 Related Tickets:  #10441      |  Differential Revisions:
-------------------------------+-------------------------------------------

Comment (by thomie):

 Actually, I don't see what is wrong with 525856. These are the 2 relevant
 changes.

 In `mk/test.mk`:
 {{{
 -       -e 'config.compiler="$(TEST_HC)"' \
 +       -e 'config.compiler="\"$(TEST_HC)\""' \
 }}}

 In `config/ghc`:
 {{{
 -    h = os.popen('"' + config.compiler + '" --info', 'r')
 +    h = os.popen(config.compiler + ' --info', 'r')
 }}}

 That should give the same result, shouldn't it?


 In mk/test.mk there are 3 pairs of quotes:
 * outer ' : this is a shell string
 * outer " : this is a python string
 * inner " : this is a path

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10449#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list