[GHC] #10093: Library configure scripts should not clobber CPPFLAGS nor LDFLAGS

[GHC]

#10093: Library configure scripts should not clobber CPPFLAGS nor LDFLAGS
-------------------------------------+-------------------------------------
        Reporter:  PHO               |                   Owner:
            Type:  bug               |                  Status:  patch
        Priority:  normal            |               Milestone:
       Component:  Build System      |                 Version:  7.11
      Resolution:                    |                Keywords:
Operating System:  Unknown/Multiple  |            Architecture:
 Type of failure:  Runtime crash     |  Unknown/Multiple
      Blocked By:                    |               Test Case:
 Related Tickets:                    |                Blocking:
                                     |  Differential Revisions:  Phab:D663
-------------------------------------+-------------------------------------

Comment (by Austin Seipp <austin@…>):

 In [changeset:"9caf71a8d9293cfebdbb5b28e2d6a455ad126882/ghc"]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="9caf71a8d9293cfebdbb5b28e2d6a455ad126882"
 Do not clobber CPPFLAGS nor LDFLAGS, fixes #10093

 Summary: Append -I/-L flags to CPPFLAGS/LDFLAGS instead of clobbering.

 Test Plan: Install libiconv into /some/non-standard/path. Set
 CONF_GCC_LINKER_OPTS_STAGE{0,1,2} to -Wl,-rpath,/some/non-
 standard/path/lib. And then run ./configure with arguments --with-iconv-
 includes=/some/non-standard/path/include and --with-iconv-libraries=/some
 /non-standard/path/lib

 Reviewers: hvr, austin

 Reviewed By: austin

 Subscribers: thomie, PHO

 Differential Revision: https://phabricator.haskell.org/D663

 GHC Trac Issues: #10093
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10093#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler