[GHC] #11019: ApiAnnotations: Make all RdrName occurences Located

GHC ghc-devs at haskell.org
Mon Dec 21 10:12:08 UTC 2015


#11019: ApiAnnotations: Make all RdrName occurences Located
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.0.1
       Component:  Compiler          |              Version:  7.10.2
      Resolution:  fixed             |             Keywords:
                                     |  ApiAnnotations
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:1512
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"d8ed20c8772bee5eb83719c804121374157cf9b6/ghc"
 d8ed20c8/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="d8ed20c8772bee5eb83719c804121374157cf9b6"
 Add Location to RdrName in FieldOcc

 Summary:
 Post #11019, there have been some new instances of RdrName that are not
 located, in particular

 ```#!hs
 data FieldOcc name = FieldOcc { rdrNameFieldOcc  :: RdrName
                               , selectorFieldOcc :: PostRn name name
                               }

 data AmbiguousFieldOcc name
   = Unambiguous RdrName (PostRn name name)
   | Ambiguous   RdrName (PostTc name name)
   deriving (Typeable)
 ```
 Add locations to them

 Updates haddock submodule to match

 Test Plan: ./validate

 Reviewers: goldfire, hvr, bgamari, austin

 Reviewed By: hvr

 Subscribers: hvr, thomie, mpickering

 Differential Revision: https://phabricator.haskell.org/D1670

 GHC Trac Issues: #11258
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11019#comment:7>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list