[GHC] #11158: Combine exprIsTrivial and cpe_ExprIsTrivial

GHC ghc-devs at haskell.org
Thu Dec 3 10:58:38 UTC 2015


#11158: Combine exprIsTrivial and cpe_ExprIsTrivial
-------------------------------------+-------------------------------------
           Reporter:  simonpj        |             Owner:
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:
          Component:  Compiler       |           Version:  7.10.2
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 Look at `CoreUtils.exprIsTrivial` and `CorePrep.cpe_ExprIsTrivial`.  They
 are identical!

 The latter has a comment saying
 {{{
 cpe_ExprIsTrivial :: CoreExpr -> Bool
 -- Version that doesn't consider an scc annotation to be trivial.
 }}}
 but the code does not treat ticks any differently.

 So the question is: '''are they supposed to be different'''? And if not,
 can we just combine them?

 Peter W, Simon M: this is your territory.  I don't understand tick stuff
 well enough.

 Simon

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11158>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list