[GHC] #10692: Replace (SourceText, FastString) with WithSourceText data type

[GHC]

#10692: Replace (SourceText,FastString) with WithSourceText data type
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                   Owner:  alanz
            Type:  bug               |                  Status:  new
        Priority:  normal            |               Milestone:
       Component:  Compiler          |                 Version:  7.11
      Resolution:                    |                Keywords:
Operating System:  Unknown/Multiple  |            Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |               Test Case:
      Blocked By:                    |                Blocking:
 Related Tickets:                    |  Differential Revisions:
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"15dd7007275a5dcdae2c9f104773eceaa56590dc/ghc"
 15dd7007/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="15dd7007275a5dcdae2c9f104773eceaa56590dc"
 Replace (SourceText,FastString) with StringLiteral data type

 Summary:
 Phab:D907 introduced SourceText for a number of data types, by replacing
 FastString with (SourceText,FastString). Since this has an Outputable
 instance, no warnings are generated when ppr is called on it, but
 unexpected output is generated. See Phab:D1096 for an example of this.

 Replace the (SourceText,FastString) tuples with a new data type,
 ```lang=hs
 data StringLiteral = StringLiteral SourceText FastString
 ```

 Update haddock submodule accordingly

 Test Plan: ./validate

 Reviewers: hvr, austin, rwbarton, trofi, bgamari

 Reviewed By: trofi, bgamari

 Subscribers: thomie, trofi, rwbarton, mpickering

 Differential Revision: https://phabricator.haskell.org/D1101

 GHC Trac Issues: #10692
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10692#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler