[GHC] #10254: parser : the API annotation on opt_sig is being discarded

GHC ghc-devs at haskell.org
Tue Apr 14 06:20:03 UTC 2015


#10254: parser : the API annotation on opt_sig is being discarded
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                   Owner:  alanz
            Type:  bug               |                  Status:  patch
        Priority:  normal            |               Milestone:  7.10.2
       Component:  Compiler          |                 Version:  7.10.1
  (Parser)                           |                Keywords:
      Resolution:                    |  ApiAnnotations
Operating System:  Unknown/Multiple  |            Architecture:
 Type of failure:  None/Unknown      |  Unknown/Multiple
      Blocked By:                    |               Test Case:
 Related Tickets:                    |                Blocking:
                                     |  Differential Revisions:  Phab:D822
-------------------------------------+-------------------------------------

Comment (by Austin Seipp <austin@…>):

 In [changeset:"919b51174163907d2bc3bb41aadf56aa8bb42e9b/ghc"]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="919b51174163907d2bc3bb41aadf56aa8bb42e9b"
 parser : the API annotation on opt_sig is being discarded

 The opt_sig production is defined as

   opt_sig :: { ([AddAnn],Maybe (LHsType RdrName)) }
           : {- empty -}                   { ([],Nothing) }
           | '::' sigtype                  { ([mj AnnDcolon $1],Just $2) }

 It is used in the alt and decl_no_th productions, but neither of them
 add the returned annotations.

 This commit captures the annotations in the calling productions.

 Reviewed By: austin

 Differential Revision: https://phabricator.haskell.org/D822

 GHC Trac Issues: #10254
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10254#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list