[GHC] #8781: check if GNU nm is really needed and if so let configure detect gnm

GHC ghc-devs at haskell.org
Thu Mar 27 09:28:03 UTC 2014


#8781: check if GNU nm is really needed and if so let configure detect gnm
----------------------------------------+-----------------------------
        Reporter:  maeder               |            Owner:  kgardas
            Type:  feature request      |           Status:  patch
        Priority:  normal               |        Milestone:
       Component:  Build System         |          Version:  7.8.1-rc1
      Resolution:                       |         Keywords:
Operating System:  Solaris              |     Architecture:  x86
 Type of failure:  Building GHC failed  |       Difficulty:  Unknown
       Test Case:                       |       Blocked By:
        Blocking:                       |  Related Tickets:
----------------------------------------+-----------------------------

Comment (by maeder):

 Yes, also not bad. The unused "r" in the first case should be a "_". The
 pattern
 "x0 :  _  : x2 : x3 : []" should be "[x0, _, x2, x3]".

 Following stripPrefix the actual "prefix" is missing.

 The actual cases for "case ... of" should be (less indented) on separate
 lines in order to avoid re-intenting lines when changing (ie. names) in
 "size <- case readHex x2 of".

 Also after "do" a line break should follow (for the same reason as after
 "of")
 (If the do-notation based on the monad instance is really an improvement
 is a matter of taste.)

 The comments clutter the code too much (in my eyes, but that's again a
 matter of taste)

 One advantage over my code is, that "C" is matched by a pattern (rather
 than using the Eq instance).

 After this style discussion I suggest, that Karel should create an
 improved patch and Austin decides to apply it.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8781#comment:31>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list