[GHC] #8793: Improve GHC.Event.IntTable performance

GHC ghc-devs at haskell.org
Tue Mar 11 15:27:06 UTC 2014


#8793: Improve GHC.Event.IntTable performance
--------------------------------------------+------------------------------
        Reporter:  cdk                      |            Owner:
            Type:  task                     |           Status:  patch
        Priority:  normal                   |        Milestone:  7.10.1
       Component:  libraries/base           |          Version:  7.6.3
      Resolution:                           |         Keywords:
Operating System:  Unknown/Multiple         |     Architecture:
 Type of failure:  Runtime performance bug  |  Unknown/Multiple
       Test Case:                           |       Difficulty:  Unknown
        Blocking:                           |       Blocked By:
                                            |  Related Tickets:
--------------------------------------------+------------------------------

Comment (by bos):

 Hi, cdk, I'll echo Johan's feedback: your patch is not reviewable. I have
 read it for several minutes, and I cannot tell what or where your real
 changes are, as opposed to all of the gratuitous reformatting you did. (As
 Johan mentions, the reformatting is discourteous, as well as obscuring the
 substance of the change.)

 If you would like this change to go in, please resubmit it as one or two
 minimal patches that do not reformat code except as necessary for semantic
 purposes, and that make it easy for a reviewer to tell what is going on.

 Thanks.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8793#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list