[GHC] #8886: sync-all: END actions result in confusing error message

[GHC]

#8886: sync-all: END actions result in confusing error message
-------------------------------+-------------------------------------------
        Reporter:  fw          |            Owner:  hvr
            Type:  bug         |           Status:  patch
        Priority:  normal      |        Milestone:
       Component:  Trac & Git  |          Version:
      Resolution:              |         Keywords:  sync-all
Operating System:              |     Architecture:  Unknown/Multiple
  Unknown/Multiple             |       Difficulty:  Easy (less than 1 hour)
 Type of failure:              |       Blocked By:
  None/Unknown                 |  Related Tickets:
       Test Case:              |
        Blocking:              |
-------------------------------+-------------------------------------------

Comment (by thomie):

 Ok, you're right that changing the directory is not needed.

 But one thing I don't understand: why are those checks in the `END` block,
 if not for running even on an error. Wouldn't they be better placed
 straight in the main function then? Would make things simpler. I guess the
 author of those old repository checks in the `END` block thought about
 potential errors that could occur, and deemed it necessary to show those
 warnings. Yes it obscures the initial error, but maybe that error is
 caused by having an old repository in the first place.

 The bug that still stands is getting false warnings about old time library
 being present when running another command before `sync-all get`. My patch
 fixes that.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8886#comment:7>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler