[GHC] #8646: Distinguish between update frames in rts/Printer.c

GHC ghc-devs at haskell.org
Fri Jan 3 12:20:00 UTC 2014


#8646: Distinguish between update frames in rts/Printer.c
-------------------------------------+------------------------------------
        Reporter:  Tarrasch          |            Owner:  simonmar
            Type:  feature request   |           Status:  patch
        Priority:  lowest            |        Milestone:  _|_
       Component:  Runtime System    |          Version:  7.6.3
      Resolution:                    |         Keywords:
Operating System:  Unknown/Multiple  |     Architecture:  Unknown/Multiple
 Type of failure:  None/Unknown      |       Difficulty:  Unknown
       Test Case:                    |       Blocked By:
        Blocking:                    |  Related Tickets:
-------------------------------------+------------------------------------

Comment (by ezyang):

 Your function has an invariant, "must be an UPDATE_FRAME". So logically,
 it should check if that invariant is violated. I think your check in (1)
 is the right one but I haven't double-checked.

 If an invariant is violated, barfing seems to be the right thing to do.
 Honestly, I would also barf when you expected an update frame but didn't
 get one.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8646#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list