<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">I have suggested further precision in the spec. <a href="https://github.com/ghc-proposals/ghc-proposals/pull/434#issuecomment-1959465348">And I strongly urge that we use a -W flag not -f flag to control these warnings. I have suggested a design in </a>my comment</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">With that done, I approve</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">Simon<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 21 Feb 2024 at 10:41, Moritz Angermann <<a href="mailto:moritz.angermann@gmail.com">moritz.angermann@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Sorry for the late reply. Last week was LNY week 😓 Just catching up on all the work and other stuff.<div><br></div><div>I'm with Eric, that this seems fine. And while the -f / -W part is discussed in the alternatives section, I can see reasons for both.<br></div><div><br></div><div>Guess we'll have to see how this plays out. I'm fine with -f or -W and as such +1 from me.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 20 Feb 2024 at 05:21, Eric Seidel <<a href="mailto:eric@seidel.io" target="_blank">eric@seidel.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I'm generally fine with this proposal, but does it seem strange to anyone else that this is a -f flag rather than a new set of -W flags?<br>
<br>
On Thu, Feb 15, 2024, at 02:23, Chris Dornan wrote:<br>
> Indeed — just a gentle reminder that the deadline for amending or <br>
> objecting to this proposal is this coming Monday 19th.<br>
><br>
> Chris<br>
><br>
>> On 15 Feb 2024, at 07:58, Arnaud Spiwack <<a href="mailto:arnaud.spiwack@tweag.io" target="_blank">arnaud.spiwack@tweag.io</a>> wrote:<br>
>> <br>
>> For the record, Jakob has amended the proposal with the flag on by default. I'm now fully good with the proposal.<br>
>> <br>
>> On Wed, 14 Feb 2024 at 14:22, Chris Dornan <<a href="mailto:chris@chrisdornan.com" target="_blank">chris@chrisdornan.com</a>> wrote:<br>
>>> Thanks Arnaud — I agree with you and have said as much in the thread and asked Jakob to clarify.<br>
>>> <br>
>>>> On 13 Feb 2024, at 16:57, Arnaud Spiwack <<a href="mailto:arnaud.spiwack@tweag.io" target="_blank">arnaud.spiwack@tweag.io</a>> wrote:<br>
>>>> <br>
>>>> I noticed that the default value of the flag is unspecified (I believe that the flag should be on by default, as deactivating transitively unused bindings is pretty situational in my opinion; we may even decide to accept the proposal but without the flag, though I have a feeling that the author wouldn't be willing to implement the flagless version). I made a comment to that effect on Github.<br>
>>>> <br>
>>>> The rest of the proposal looks good to me.<br>
>>>> <br>
>>>> On Tue, 13 Feb 2024 at 11:59, Chris Dornan <<a href="mailto:chris@chrisdornan.com" target="_blank">chris@chrisdornan.com</a>> wrote:<br>
>>>>> Proposal: Fine-Grained Unused Warnings (#42)<br>
>>>>> Author: Jakob Brünker<br>
>>>>> Rendered proposal: <a href="https://github.com/JakobBruenker/ghc-proposals/blob/fine-grained-unused/proposals/0000-fine-grained-unused-warnings.rst" rel="noreferrer" target="_blank">https://github.com/JakobBruenker/ghc-proposals/blob/fine-grained-unused/proposals/0000-fine-grained-unused-warnings.rst</a><br>
>>>>> Discussion: <a href="https://github.com/ghc-proposals/ghc-proposals/pull/434" rel="noreferrer" target="_blank">https://github.com/ghc-proposals/ghc-proposals/pull/434</a><br>
>>>>> Recommendation: Acceptance<br>
>>>>> <br>
>>>>> ## Summary<br>
>>>>> <br>
>>>>> The proposal partitions warning about unused identifiers into <br>
>>>>> <br>
>>>>> a) bindings that are truly unused (not mentioned anywhere) and <br>
>>>>> b) bindings that are mentioned exclusively in code that is itself (transitively) unused,<br>
>>>>> <br>
>>>>> and suppresses the latter unless the -freport-indirectly-unused-bindings flag is specified.<br>
>>>>> <br>
>>>>> The proposal is concise with some well-chosen examples and I recommend everyone at least skim it.<br>
>>>>> <br>
>>>>> I propose that we accept this proposal if nobody objects by the start of next week (Monday, 2024-02-19).<br>
>>>>> <br>
>>>>> Chris<br>
>>>>> _______________________________________________<br>
>>>>> ghc-steering-committee mailing list<br>
>>>>> <a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
>>>>> <a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
>>>> <br>
>>>> <br>
>>>> -- <br>
>>>> Arnaud Spiwack<br>
>>>> Director, Research at <a href="https://moduscreate.com" rel="noreferrer" target="_blank">https://moduscreate.com</a> and <a href="https://tweag.io" rel="noreferrer" target="_blank">https://tweag.io</a>.<br>
>>> <br>
>> <br>
>> <br>
>> -- <br>
>> Arnaud Spiwack<br>
>> Director, Research at <a href="https://moduscreate.com" rel="noreferrer" target="_blank">https://moduscreate.com</a> and <a href="https://tweag.io" rel="noreferrer" target="_blank">https://tweag.io</a>.<br>
><br>
> _______________________________________________<br>
> ghc-steering-committee mailing list<br>
> <a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
> <a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
_______________________________________________<br>
ghc-steering-committee mailing list<br>
<a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
<a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
</blockquote></div>
_______________________________________________<br>
ghc-steering-committee mailing list<br>
<a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
<a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
</blockquote></div>