<div dir="ltr"><div>This proposal could break a few things, in particular if someone made a Read instance for a type with sized integer fields (though considering how the Show instance looks, I'd probably not have gone that path personally, so I expect it to be quite rare).</div><div><br></div><div>Probably, just in case, this should be advertised pretty loudly in the release note.</div><div><br></div><div>Apart from that, this is a clear improvement. The author's patch even removes some net lines from GHC, which is always welcome.</div><div><br></div><div>I'm in favour.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 1 Jul 2023 at 12:38, Joachim Breitner <<a href="mailto:mail@joachim-breitner.de">mail@joachim-breitner.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
CLC appreciates the ping but says it’s out of scope:<br>
<a href="https://github.com/haskell/core-libraries-committee/issues/183#issuecomment-1615827603" rel="noreferrer" target="_blank">https://github.com/haskell/core-libraries-committee/issues/183#issuecomment-1615827603</a><br>
<br>
Cheers,<br>
Joachim<br>
<br>
Am Donnerstag, dem 29.06.2023 um 08:16 +0100 schrieb Simon Peyton<br>
Jones:<br>
> Looks good to me.<br>
> <br>
> I have suggested that @monoidal opens a CLC issue.  (This change the<br>
> `base` API.)<br>
> <br>
> Simon<br>
> <br>
> On Thu, 29 Jun 2023 at 07:21, Joachim Breitner<br>
> <<a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a>> wrote:<br>
> > Dear committee,<br>
> > <br>
> > Krzysztof Gogolewski in<br>
> > <a href="https://github.com/ghc-proposals/ghc-proposals/pull/596" rel="noreferrer" target="_blank">https://github.com/ghc-proposals/ghc-proposals/pull/596</a><br>
> > amends the sized literals proposal so that GHC uses the syntax <br>
> > 42#Int8 instead of (intToInt8# 42#) in the stock derived Show<br>
> > instances<br>
> > for data types with sized unboxed numbers.<br>
> > <br>
> > Implementation is also ready.<br>
> > <br>
> > Now that we have a syntax for these literals it’s clear that we<br>
> > want to<br>
> > use them in the show instances. <br>
> > <br>
> > <br>
> > There is no risk of breaking Show-Read-roundtripping, as Read<br>
> > instances<br>
> > cannot be derived (at the moment).<br>
> > <br>
> > This is a change in behavior of Show, so we should think for a<br>
> > moment<br>
> > how this affects stability. But none of the libraries in<br>
> > libraries/, in<br>
> > particularly not base, are affected by this change, according to<br>
> > Krzysztof.<br>
> > <br>
> > So I recommend to accept this.<br>
> > <br>
> > Cheers,<br>
> > Joachim<br>
> > <br>
> > <br>
> > <br>
> > _______________________________________________<br>
> > ghc-steering-committee mailing list<br>
> > <a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
> > <a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
<br>
-- <br>
Joachim Breitner<br>
  <a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a><br>
  <a href="http://www.joachim-breitner.de/" rel="noreferrer" target="_blank">http://www.joachim-breitner.de/</a><br>
<br>
_______________________________________________<br>
ghc-steering-committee mailing list<br>
<a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
<a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
</blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr">Arnaud Spiwack<br>Director, Research at <a href="https://moduscreate.com" rel="noopener noreferrer" target="_blank">https://moduscreate.com</a> and <a href="https://tweag.io" rel="noopener noreferrer" target="_blank">https://tweag.io</a>.</div></div>