<div dir="ltr">I don't like this proposal. I guess it is mostly a matter of taste, but I think that comas should be used a separator and not a terminator. I don't really buy either the CPP or "cleaner diffs" motivation.<div><br></div><div>Joachim's proposal about the export warnings does make sense though.</div><div><div><div><br><div>Cheers,</div><div>-Iavor<br><div><br></div><div><br></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, May 3, 2018 at 2:38 AM Simon Marlow <<a href="mailto:marlowsd@gmail.com">marlowsd@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>I support both adding ExtraCommas (minus constraint tuples) and Joachim's suggestion to modify the warning for duplicate exports. Both of these are useful.<br><br></div>The "cleaner diffs" motivation is more compelling than the CPP argument, in my opinion. I often have to work with Python where it's common practice to include trailing commas in multiline lists, and I miss it in Haskell.<br><br></div>Cheers<br></div></div><div dir="ltr">Simon<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 1 May 2018 at 03:59, Joachim Breitner <span dir="ltr"><<a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<span><br>
<br>
Am Montag, den 30.04.2018, 19:20 -0500 schrieb Christopher Allen:<br>
> <a href="https://github.com/ghc-proposals/ghc-proposals/pull/87" rel="noreferrer" target="_blank">https://github.com/ghc-proposals/ghc-proposals/pull/87</a><br>
> <br>
> With the provisos mentioned by Simon starting here in mind:<br>
> <a href="https://github.com/ghc-proposals/ghc-proposals/pull/87#issuecomment-385536587" rel="noreferrer" target="_blank">https://github.com/ghc-proposals/ghc-proposals/pull/87#issuecomment-385536587</a><br>
<br>
</span>I am not against the proposal, but in the interest of fighting<br>
extension fatigue I’d like to draw your attention to this (which I had <br>
just posted at <a href="https://github.com/ghc-proposals/ghc-proposals/pull/87#issuecomment-385581915" rel="noreferrer" target="_blank">https://github.com/ghc-proposals/ghc-proposals/pull/87#issuecomment-385581915</a>)<br>
<br>
<br>
If the motivation is really mainly about subexports lists, then we<br>
could simply tell GHC to accept<br>
<br>
module Foo<br>
(<br>
Foo(A),<br>
Foo(B),<br>
)<br>
where<br>
<br>
without warning about the duplicate export of `Foo`.<br>
<br>
<br>
Is this good enough to solve the subexport list problem for CPP users?<br>
(probably yes)<br>
<br>
Do we still want ExtraCommas, because it is also useful in lists and<br>
other syntactic constructs?<br>
(probably probably; I could be swayed either way).<br>
<br>
<br>
Cheers,<br>
Joachim<br>
<span class="m_-6584079504495808273HOEnZb"><font color="#888888"><br>
-- <br>
Joachim Breitner<br>
<a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a><br>
<a href="http://www.joachim-breitner.de/" rel="noreferrer" target="_blank">http://www.joachim-breitner.de/</a><br>
</font></span><br>_______________________________________________<br>
ghc-steering-committee mailing list<br>
<a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
<a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
<br></blockquote></div><br></div>
_______________________________________________<br>
ghc-steering-committee mailing list<br>
<a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
<a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
</blockquote></div>