<div dir="ltr">I agree that we should accept #71</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 8, 2018 at 2:24 AM Simon Marlow <<a href="mailto:marlowsd@gmail.com">marlowsd@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I propose that we accept the proposal <br><br> add incomplete-uni-patterns and incomplete-record-updates to -Wall<br><div><div><br><a href="https://github.com/ghc-proposals/ghc-proposals/pull/71" rel="noreferrer" target="_blank">https://github.com/ghc-proposals/ghc-proposals/pull/71<br></a></div><div><a href="https://github.com/ghc-proposals/ghc-proposals/pull/71" rel="noreferrer" target="_blank"><br></a></div><div>Both warnings are avoidable and considered bad style, which makes them appropriate to include in -Wall.<br></div><div><br></div><div>The reason that -Wincomplete-uni-patterns wasn't originally made part of -Wall was due to worries about noisiness (<a href="https://ghc.haskell.org/trac/ghc/ticket/4905" rel="nofollow" target="_blank">https://ghc.haskell.org/trac/ghc/ticket/4905</a>), but that's not a valid concern. -Wall is intentionally a moving target, if you want to stay Wall-clean you accept that new compiler releases may entail some work.<br></div><div><br></div></div><div>Basically I think this is a no-brainer.</div><div><br></div><div>Cheers</div><div>Simon</div><div><br></div></div>
_______________________________________________<br>
ghc-steering-committee mailing list<br>
<a href="mailto:ghc-steering-committee@haskell.org" target="_blank">ghc-steering-committee@haskell.org</a><br>
<a href="https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee" rel="noreferrer" target="_blank">https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee</a><br>
</blockquote></div>