<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail_default" style="font-family:tahoma,sans-serif">
It is advisable to do this after<br>
rebasing, especially if the rebase involves changes to the module<br>
structure or build system.
</span></blockquote><div><br></div><div style="font-family:tahoma,sans-serif" class="gmail_default">But *any* commit could involve such a change. Isn't it a goal of Hadrian to respond to, well, changes? For example, it is clever enough to rebuild Hadrian itself when it changes.</div><div style="font-family:tahoma,sans-serif" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif" class="gmail_default">It's a bit unsatisfying to say "it'll usually work, but if anything strange happens, just make clean and try again". Understandable perhaps, but not satisfying.</div><div style="font-family:tahoma,sans-serif" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif" class="gmail_default">Simon<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 11 Jul 2022 at 16:19, Sylvain Henry <<a href="mailto:sylvain@haskus.fr">sylvain@haskus.fr</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hi Simon,</p>
<p>You have to re-run `./configure` in cases like this. It's because
`compiler/ghc.cabal` is generated from `compiler/<a href="http://ghc.cabal.in" target="_blank">ghc.cabal.in</a>` by
`./configure`. This isn't tracked by Hadrian.<br>
</p>
<p>><span class="gmail_default" style="font-family:tahoma,sans-serif">Surely that should not
happen?</span><span class="gmail_default" style="font-family:tahoma,sans-serif"> I'll try make clean; but
isn't this a bug?</span></p>
<p>Hopefully when `make` build system will be removed it should be
easy to make Hadrian (instead of `./configure`) generate and track
this file. In fact I already did this in a MR more than a year ago
but it was blocked on make-removal.</p>
<p>Sylvain<br>
</p>
<p><br>
</p>
<div>On 11/07/2022 17:09, Simon Peyton Jones
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div class="gmail_default" style="font-family:tahoma,sans-serif">
<span class="gmail_default" style="font-family:tahoma,sans-serif"></span><span class="gmail_default" style="font-family:tahoma,sans-serif">
<span class="gmail_default" style="font-family:tahoma,sans-serif"></span>(apols for
premature send)</span></div>
<div class="gmail_default" style="font-family:tahoma,sans-serif"><span class="gmail_default" style="font-family:tahoma,sans-serif"><br>
</span></div>
<div class="gmail_default" style="font-family:tahoma,sans-serif"><span class="gmail_default" style="font-family:tahoma,sans-serif">I am working on a
branch of GHC, actually on !8210. I have rebased on
master. Then I say <br>
</span></div>
<div class="gmail_default" style="font-family:tahoma,sans-serif"><span class="gmail_default" style="font-family:tahoma,sans-serif">hadrian/build</span></div>
<div class="gmail_default" style="font-family:tahoma,sans-serif"><span class="gmail_default" style="font-family:tahoma,sans-serif">and I get the log
below. It falls over saying <br>
</span></div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;margin-left:40px"><span class="gmail_default" style="font-family:tahoma,sans-serif">No generator for
_build/stage0/compiler/build/GHC/Unit/Module/Name.hs.</span>
</div>
</div>
<br>
<div class="gmail_quote">
<div class="gmail_attr"><span class="gmail_default" style="font-family:tahoma,sans-serif">Surely that should
not happen?</span></div>
<div class="gmail_attr"><span class="gmail_default" style="font-family:tahoma,sans-serif"><br>
</span></div>
<div class="gmail_attr"><span class="gmail_default" style="font-family:tahoma,sans-serif">I'll try make clean;
but isn't this a bug?</span></div>
<div class="gmail_attr"><span class="gmail_default" style="font-family:tahoma,sans-serif"><br>
</span></div>
<div class="gmail_attr"><span class="gmail_default" style="font-family:tahoma,sans-serif">Simon<br>
</span></div>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
ghc-devs mailing list
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a>
</pre>
</blockquote>
</div>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote></div>