<div dir="ltr"><div>FYI, it is possible to make a "permalink" on github, which points to the code at a specific commit. Perhaps gitlab has something similar?</div><div><br></div><div>Alan<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 28 Dec 2021 at 19:28, Richard Eisenberg <<a href="mailto:lists@richarde.dev">lists@richarde.dev</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">We could always make a hyperlink to the source code as hosted on GitLab. But I actually argue not to: such links would quickly become outdated, in one of two ways: either we make a permalink, in which case the linked Note text will become outdated; or we make a link to a particular file & line, in which case the Note might move somewhere else. Instead, just by naming the Note title, we have a slightly-harder-to-use link, where you use it by grepping the source code. This is less convenient, but it will stay up-to-date. Until we have better tooling to, say, create an HTML anchor based on a Note, I think this is the best we can do.<div><br></div><div>Richard<br><div><br><blockquote type="cite"><div>On Dec 28, 2021, at 12:10 PM, Benjamin Redelings <<a href="mailto:benjamin.redelings@gmail.com" target="_blank">benjamin.redelings@gmail.com</a>> wrote:</div><br><div><p style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">I was thinking about the relationship between the wiki and the notes in the GHC source.</p><p style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">Would it be possible to link directly to [compiler notes] in the GHC source from the wiki, using hyperlinks? Right now, I'm seeing references that look like: (See<span> </span><code>Note [Constraint flavours]</code>.)</p><p style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">(I can see the motivation to include comments in the source, but I also think that the wiki is more discoverable than the compiler source code. So, in the interests of pursuing both approaches, it would be nice to be able to link to notes FROM the wiki. I suppose one could include a hyperlink to the file on github that contains the note...)</p><p style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">I'm not sure how much web infrastructure would be required to make hyperlinks for notes...<br></p><p style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">-BenRI<br></p><div style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">On 11/8/21 5:35 AM, Simon Peyton Jones wrote:<br></div><blockquote type="cite" style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div><p style="margin-left:36pt">Is there anywhere on the GHC wiki that explains how to interpret this output, and says that the type and dictionary applications ARE there, just not shown by '-ddump-tc'?<u></u><u></u></p><p style="margin-left:36pt">Perhaps it would be helpful to add some basic description of what comes out of the typechecker to a page like this one? (below)<u></u><u></u></p><p style="margin-left:36pt"> <span> </span><a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2F-%2Fwikis%2Fcommentary%2Fcompiler%2Fhsc-main&data=04%7C01%7Csimonpj%40microsoft.com%7Cab59b17d2f394945ad1e08d9a2b96c81%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637719740212483767%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WZL1VADZPUlaOACd58K1XZO5MzPOKrfLFMSuBD%2FGW44%3D&reserved=0" style="color:blue;text-decoration:underline" target="_blank">https://gitlab.haskell.org/ghc/ghc/-/wikis/commentary/compiler/hsc-main</a><u></u><u></u></p><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span>Yes it would! Would you care to start such a wiki page (a new one; don’t just clutter up the one you point to)? You can write down what you know. Don’t worry if you aren’t 100% sure – we can correct it. And if you outright don’t know, leave a “What should I say here?” note.<u></u><u></u></span></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span><u></u> <u></u></span></div><p style="margin-left:36pt">"This late desugaring is somewhat unusual. It is much more common to desugar the program before typechecking, or renaming, because that presents the renamer and typechecker with a much smaller language to deal with. However, GHC's organisation means that<u></u><u></u></p><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span>This note is now slightly out of date. We are now, very carefully, doing some desugaring<span> </span><b>before</b><span> </span>typechecking. See<u></u><u></u></span></div><ul style="margin-bottom:0cm;margin-top:0cm" type="disc"><li style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span>Note [Handling overloaded and rebindable constructs] in GHC.Rename.Expr<u></u><u></u></span></li><li style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span>Note [Rebindable syntax and HsExpansion] in GHC.Hs.Expr<u></u><u></u></span></li></ul><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span><u></u> <u></u></span></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span>You can and should point to these and similar Notes from the wiki page you write. Indeed there may be some part of what you write that would be better framed as Note in GHC’s source code.<u></u><u></u></span></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span><u></u> <u></u></span></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span>Thanks!<u></u><u></u></span></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span><u></u> <u></u></span></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span>Simon<u></u><u></u></span></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span><u></u> <u></u></span></div><div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span style="font-size:8pt">PS: I am leaving Microsoft at the end of November 2021, at which point<span> </span><a href="mailto:simonpj@microsoft.com" style="color:blue;text-decoration:underline" target="_blank"><span style="color:rgb(5,99,193)">simonpj@microsoft.com</span></a><span> </span>will cease to work. Use<span> </span><a href="mailto:simon.peytonjones@gmail.com" style="color:blue;text-decoration:underline" target="_blank"><span style="color:rgb(5,99,193)">simon.peytonjones@gmail.com</span></a><span> </span>instead. (For now, it just forwards to<span> </span><a href="mailto:simonpj@microsoft.com" style="color:blue;text-decoration:underline" target="_blank">simonpj@microsoft.com</a>.)<u></u><u></u></span></div></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><span><u></u> <u></u></span></div><div style="border-style:none none none solid;border-left:1.5pt solid blue;padding:0cm 0cm 0cm 4pt"><div><div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(225,225,225);padding:3pt 0cm 0cm"><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><b><span lang="EN-US">From:</span></b><span lang="EN-US"><span> </span>ghc-devs<span> </span><a href="mailto:ghc-devs-bounces@haskell.org" style="color:blue;text-decoration:underline" target="_blank"><ghc-devs-bounces@haskell.org></a><span> </span><b>On Behalf Of<span> </span></b>Benjamin Redelings<br><b>Sent:</b><span> </span>08 November 2021 13:12<br><b>To:</b><span> </span>Richard Eisenberg<span> </span><a href="mailto:lists@richarde.dev" style="color:blue;text-decoration:underline" target="_blank"><lists@richarde.dev></a><br><b>Cc:</b><span> </span><a href="mailto:ghc-devs@haskell.org" style="color:blue;text-decoration:underline" target="_blank">ghc-devs@haskell.org</a><br><b>Subject:</b><span> </span>Re: Output language of typechecking pass?<u></u><u></u></span></div></div></div><div style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><p>Hi,<u></u><u></u></p><blockquote style="margin-top:5pt;margin-bottom:5pt"><blockquote style="margin-top:5pt;margin-bottom:5pt"><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">Questions:<u></u><u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">1. It seems like this separation is actually necessary, in order to apply generalization only to let arguments written by the programmer, and not to let bindings introduced during desugaring. Is that right?<u></u><u></u></pre></blockquote><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">I don't think so. That is, if we did it all in one pass, I still think we could get generalization right.<u></u><u></u></pre></blockquote><p>I guess I asked this question wrong. I mean to say, if we did the two passes in the reverse order (desugaring first, followed by typechecking), that would not work, right?<u></u><u></u></p><p>As the wiki says:<u></u><u></u></p><p>"This late desugaring is somewhat unusual. It is much more common to desugar the program before typechecking, or renaming, because that presents the renamer and typechecker with a much smaller language to deal with. However, GHC's organisation means that<u></u><u></u></p><ul style="margin-bottom:0cm" type="disc"><li class="MsoNormal" style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif">error messages can display precisely the syntax that the user wrote; and<u></u><u></u></li><li class="MsoNormal" style="margin:0cm;font-size:11pt;font-family:Calibri,sans-serif">desugaring is not required to preserve type-inference properties.<u></u><u></u></li></ul><p>"<u></u><u></u></p><blockquote style="margin-top:5pt;margin-bottom:5pt"><blockquote style="margin-top:5pt;margin-bottom:5pt"><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">2. Does the output of type checking contain type lambdas?<u></u><u></u></pre></blockquote><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">Yes. See below.<u></u><u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><blockquote style="margin-top:5pt;margin-bottom:5pt"><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">3. Does the type checking pass determine where to add dictionary arguments?<u></u><u></u></pre></blockquote><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">Yes. See below.<u></u><u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><blockquote style="margin-top:5pt;margin-bottom:5pt"><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">4. Are there any other resources I should be looking at?<u></u><u></u></pre></blockquote><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">Yes. You want to enable -fprint-typechecker-elaboration (and possible -fprint-explicit-coercions). With the former, you get to see all this stuff you're looking for. It's normally suppressed so that the output resembles the user's code.<u></u><u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New""><u></u> <u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">I hope this helps!<u></u><u></u></pre><pre style="margin:0cm;font-size:10pt;font-family:"Courier New"">Richard<u></u><u></u></pre></blockquote><p>Hmm... so, I think I see how this works now. I don't think '-fprint-explicit-coercions' does anything here though.<u></u><u></u></p><p>$ ghc -ddump-tc Test2.hs -fprint-typechecker-elaboration<u></u><u></u></p><p>...<u></u><u></u></p><p>AbsBinds [a_a2hp] [$dNum_a2hB]<br> <span> </span>{Exports: [g <= g_a2hz<br> <span> </span>wrap: <>]<br> <span> </span>Exported types: g :: forall a. Num a => a -> a -> a<br> <span> </span>[LclId]<br> <span> </span>Binds: g x_aYk y_aYl = (y_aYl * x_aYk) + 1<br> <span> </span>Evidence: [EvBinds{[W] $dNum_a2hs = $dNum_a2hq<br> <span> </span>[W] $dNum_a2hw = $dNum_a2hq<br> <span> </span>[W] $dNum_a2hq = $dNum_a2hB}]}<u></u><u></u></p><p>...<u></u><u></u></p><p>The type and dictionary arguments are visible here (along with the evidence bindings), but type and dictionary applications are only visible if you use -ddump-tc-ast, which is a lot more verbose. (I don't think there is another flag that shows these applications?) Since I didn't initially know what "evidence" was, and there is nothing to say that a_a2hp is a type lambda argument, this was pretty opaque until I managed to read the tc-ast and the light went on.<u></u><u></u></p><p>I can see now that the type and dictionary arguments are added by annotating the AST.<u></u><u></u></p><p>Is there anywhere on the GHC wiki that explains how to interpret this output, and says that the type and dictionary applications ARE there, just not shown by '-ddump-tc'?<u></u><u></u></p><p>Perhaps it would be helpful to add some basic description of what comes out of the typechecker to a page like this one? (below)<u></u><u></u></p><p> <span> </span><a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2F-%2Fwikis%2Fcommentary%2Fcompiler%2Fhsc-main&data=04%7C01%7Csimonpj%40microsoft.com%7Cab59b17d2f394945ad1e08d9a2b96c81%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637719740212483767%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WZL1VADZPUlaOACd58K1XZO5MzPOKrfLFMSuBD%2FGW44%3D&reserved=0" style="color:blue;text-decoration:underline" target="_blank">https://gitlab.haskell.org/ghc/ghc/-/wikis/commentary/compiler/hsc-main</a><u></u><u></u></p><p>-BenRI</p></div></div></blockquote></div></blockquote></div><br></div></div>_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote></div>