<div dir="ltr">More like abandoned backport attempt :D</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 24, 2021 at 7:29 PM Andreas Klebinger <<a href="mailto:klebinger.andreas@gmx.at">klebinger.andreas@gmx.at</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Yes, only changing the rule did indeed cause regressions.<br>
Whichwhen not including the string changes. I don't think it's
worth<br>
having one without the other.<br>
<br>
But it seems you already backported this?<br>
See <a href="https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5263" target="_blank">https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5263</a><br>
<br>
Cheers<br>
Andreas</p>
<div>Am 22/03/2021 um 07:02 schrieb Moritz
Angermann:<br>
</div>
<blockquote type="cite">
<div dir="ltr">The commit message from <a href="https://gitlab.haskell.org/ghc/ghc/-/commit/f10d11fa49fa9a7a506c4fdbdf86521c2a8d3495" target="_blank">https://gitlab.haskell.org/ghc/ghc/-/commit/f10d11fa49fa9a7a506c4fdbdf86521c2a8d3495</a>,
<div>makes the changes to string seem required. Applying the
commit on its own doesn't apply cleanly and pulls in quite a</div>
<div>bit of extra dependent commits. Just applying the elem
rules appears rather risky. Thus will I agree that having that</div>
<div>would be a nice fix to have, the amount of necessary code
changes makes me rather uncomfortable for a minor release :-/</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Mar 22, 2021 at 1:58
PM Gergő Érdi <<a href="mailto:gergo@erdi.hu" target="_blank">gergo@erdi.hu</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="auto">Thanks, that makes it less appealing. In the
original thread, I got no further replies after my email
announcing my "discovery" of that commit, so I thought that
was the whole story.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Mar 22, 2021,
13:53 Viktor Dukhovni <<a href="mailto:ietf-dane@dukhovni.org" target="_blank">ietf-dane@dukhovni.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Mar 22, 2021 at
12:39:28PM +0800, Gergő Érdi wrote:<br>
<br>
> I'd love to have this in a GHC 8.10 release:<br>
> <a href="https://mail.haskell.org/pipermail/ghc-devs/2021-March/019629.html" rel="noreferrer noreferrer" target="_blank">https://mail.haskell.org/pipermail/ghc-devs/2021-March/019629.html</a><br>
<br>
This is already in 9.0, 9.2 and master, but it is a rather
non-trivial<br>
change, given all the new work that went into the String
case. So I am<br>
not sure it is small/simple enough to make for a
compelling backport.<br>
<br>
There's a lot of recent activity in this space. See also<br>
<<a href="https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5259" rel="noreferrer noreferrer" target="_blank">https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5259</a>>,
which is not<br>
yet merged into master, and might still be eta-reduced one
more step).<br>
<br>
I don't know whether such optimisation tweaks (not a
bugfix) are in<br>
scope for backporting, we certainly need to be confident
they'll not<br>
cause any new problems. FWIW, 5259 is dramatically
simpler...<br>
<br>
Of course we also have<br>
<<a href="https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4890" rel="noreferrer noreferrer" target="_blank">https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4890</a>>
in much the<br>
same territory, but there we're still blocked on someone
figuring out<br>
what's going on with the 20% compile-time hit with T13056,
and whether<br>
that's acceptable or not...<br>
<br>
-- <br>
Viktor.<br>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" rel="noreferrer" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote>
</div>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
ghc-devs mailing list
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a>
</pre>
</blockquote>
</div>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote></div>