<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I've started a review, but sent along what I had when dinner was ready. Hopefully more later, but don't wait up for me!<div class=""><br class=""></div><div class="">Incidentally: this is a monstrous patch, and so there is a strong incentive just to get on with it without resolving all these quibbles. I won't stand in your way on that front -- it might be better to improve this after it lands. However, I also see quite a few TODO:AZ notes. Are you intending to fix these before landing? Or do you think it's OK to merge first and then return?</div><div class=""><br class=""></div><div class="">High level piece: I'm in support of this direction of movement -- I just want to make sure that the new code is understandable and maintainable.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Richard<br class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 6, 2021, at 12:39 PM, Alan & Kim Zimmerman <<a href="mailto:alan.zimm@gmail.com" class="">alan.zimm@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">I have been running a branch in !2418[1] for just over a year to migrate the ghc-exactprint functionality directly into the GHC AST[2], and I am now satisfied that it is able to provide all the same functionality as the original.</div><div class=""><br class=""></div><div class="">This is one of the features intended for the impending 9.2.1 release, and it needs to be reviewed to be able to land. But the change is huge, as it mechanically affects most files that interact with the GHC AST.</div><div class=""><br class=""></div><div class="">So I have split out a precursor !5158 [3] with just the new types that are used to represent the annotations, so it can be a focal point for discussion.</div><div class=""><br class=""></div><div class="">It is ready for review, please comment if you have time and interest.</div><div class=""><br class=""></div><div class="">Regards</div><div class=""> Alan</div><div class=""><br class=""></div><div class="">[1] <a href="https://gitlab.haskell.org/ghc/ghc/-/merge_requests/2418" target="_blank" class="">https://gitlab.haskell.org/ghc/ghc/-/merge_requests/2418</a></div><div class="">[2] <a href="https://gitlab.haskell.org/ghc/ghc/-/issues/17638" class="">https://gitlab.haskell.org/ghc/ghc/-/issues/17638</a></div><div class="">[3] <a href="https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5158" target="_blank" class="">https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5158</a></div></div>
_______________________________________________<br class="">ghc-devs mailing list<br class=""><a href="mailto:ghc-devs@haskell.org" class="">ghc-devs@haskell.org</a><br class="">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<br class=""></div></blockquote></div><br class=""></div></div></body></html>