<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi devs,<div class=""><br class=""></div><div class="">I recently found this text at the end of <a href="https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/git/submodules" class="">https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/git/submodules</a> :</div><div class=""><br class=""></div><div class="">---</div><div class="">The CI pipeline of <a href="/ghc/ghc" data-project="1" data-reference-type="project" data-container="body" data-placement="bottom" class="gfm has-tooltip gfm-project" title="" data-original-title="GHC">ghc/ghc></a> includes a linting step to ensure that all submodules refer only to "persistent" commits of the upstream repositories (e.g. not <code class="">wip/</code> branches, which may disappear in the future). Specifically, the linter checks that any submodules refer to commits that are reachable by at least one branch that doesn't begin with the prefix <code class="">wip/</code>. Consequently, you must ensure that any submodule changes introduced in a <a href="/ghc/ghc" data-project="1" data-reference-type="project" data-container="body" data-placement="bottom" class="gfm has-tooltip gfm-project" title="" data-original-title="GHC">ghc/ghc></a> merge request are merged upstream before the merge request is added to the merge queue.</div><div class="">---</div><div class=""><br class=""></div><div class="">I don't understand what this means.</div><div class=""><br class=""></div><div class="">- By citing "ghc/ghc>", does this mean that the linter only checks for this on branches of the ghc/ghc repo? If I have a fork (e.g. rae/ghc), are these checks disabled?</div><div class=""><br class=""></div><div class="">- Does this linter stop CI from progressing to, say, running the testsuite? If so, then how can we run the testsuite via CI if we have any submodule changes? We want to run the testsuite while the work is still in progress.</div><div class=""><br class=""></div><div class="">- By "you must ensure ... before the merge request is added to the merge queue": this makes me wonder whether the linter is just a warning or an error. That is, if I must ensure it, then it suggests that CI is not ensuring it.</div><div class=""><br class=""></div><div class="">Sorry to be dense here!</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Richard</div></body></html>