<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin-top:6.0pt;
margin-right:0cm;
margin-bottom:6.0pt;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.Code, li.Code, div.Code
{mso-style-name:Code;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:14.2pt;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New",serif;
font-weight:bold;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">It would be good to know how to fix this. It’s blocking my builds.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">For some reason it doesn’t seem to kill CI<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Simon<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Simon Peyton Jones
<br>
<b>Sent:</b> 25 January 2020 20:26<br>
<b>To:</b> ghc-devs <ghc-devs@haskell.org><br>
<b>Subject:</b> stage2 build fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’m getting this with “sh validate –legacy”<o:p></o:p></p>
<p class="Code">compiler/main/DynFlags.hs:1344:15: error: [-Woverlapping-patterns, -Werror=overlapping-patterns]<o:p></o:p></p>
<p class="Code"> Pattern match is redundant<o:p></o:p></p>
<p class="Code"> In an equation for ‘settings’: settings s | otherwise = ...<o:p></o:p></p>
<p class="Code"> |<o:p></o:p></p>
<p class="Code">1344 | | otherwise = panic $ "Invalid cfg parameters." ++ exampleString<o:p></o:p></p>
<p class="Code"> | ^^^^^^^^^<o:p></o:p></p>
<p class="MsoNormal">This is when compiling the stage-2 compiler. There’s an ifdef in DynFlags thus<o:p></o:p></p>
<p class="Code">#if __GLASGOW_HASKELL__ <= 810<o:p></o:p></p>
<p class="Code"> | otherwise = panic $ "Invalid cfg parameters." ++ exampleString<o:p></o:p></p>
<p class="Code">#endif<o:p></o:p></p>
<p class="MsoNormal">but somehow it’s not triggering for the stage2 compiler.<o:p></o:p></p>
<p class="MsoNormal">Any ideas? It’s blocking a full build. <o:p></o:p></p>
<p class="MsoNormal">This #ifdef was added in 8038cbd96f4, when GHC became better at reporting redundant code.<o:p></o:p></p>
<p class="MsoNormal">Simon<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>