<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">+1 from me.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 8, 2019, at 7:19 PM, Shayne Fletcher via ghc-devs <<a href="mailto:ghc-devs@haskell.org" class="">ghc-devs@haskell.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">All sounds very sensible to me.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 8, 2019 at 2:17 PM Ben Gamari <<a href="mailto:ben@well-typed.com" class="">ben@well-typed.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">tl;dr. I would like feedback on a few proposed changes [1] to our merge<br class="">
request workflow.<br class="">
<br class="">
<br class="">
Hello everyone,<br class="">
<br class="">
Over the past six months I have been monitoring the operation of our<br class="">
merge request workflow, which arose rather organically in the wake of<br class="">
the initial move to GitLab. While it works reasonably well, there is<br class="">
clearly room for improvement:<br class="">
<br class="">
* we have no formal way to track the status of in-flight merge<br class="">
requests (e.g. for authors to mark an MR as ready for review or<br class="">
reviewers to mark work as ready for merge)<br class="">
<br class="">
* merge requests still at times languish without review<br class="">
<br class="">
* the backport protocol is somewhat error prone and requires a great<br class="">
deal of attention to ensure that patches don't slip through the<br class="">
cracks<br class="">
<br class="">
* there is no technical mechanism to prevent that under-reviewed<br class="">
patches from being merged (either intentionally or otherwise) to<br class="">
`master`<br class="">
<br class="">
To address this I propose [1] a few changes to our workflow:<br class="">
<br class="">
1. Define explicit phases of the merge request lifecycle,<br class="">
systematically identified with labels. This will help to make it<br class="">
clear who is responsible for a merge request at every stage of its<br class="">
lifecycle.<br class="">
<br class="">
2. Make it clear that it is the contributor's responsibility to<br class="">
identify reviewers for their merge requests.<br class="">
<br class="">
3. Institute a final pre-merge sanity check to ensure that<br class="">
patches are adequately reviewed, documented, tested, and have had<br class="">
their ticket and MR metadata updated.<br class="">
<br class="">
Note that this is merely a proposal; I am actively seeking input from<br class="">
the developer community. Do let me know what you think.<br class="">
<br class="">
Cheers,<br class="">
<br class="">
- Ben<br class="">
<br class="">
<br class="">
[1] <a href="https://gitlab.haskell.org/ghc/ghc/wikis/proposals/merge-request-workflow" rel="noreferrer" target="_blank" class="">https://gitlab.haskell.org/ghc/ghc/wikis/proposals/merge-request-workflow</a><br class="">
_______________________________________________<br class="">
ghc-devs mailing list<br class="">
<a href="mailto:ghc-devs@haskell.org" target="_blank" class="">ghc-devs@haskell.org</a><br class="">
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank" class="">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br class="">
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div style="letter-spacing:normal;padding:10px 0px 10px 10px;width:300px;max-width:300px;color:rgb(26,40,77);font-size:12px" class=""><div style="color:rgb(33,33,33);font-size:13px" class=""><div class=""><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div style="padding:10px 0px 10px 10px;width:300px;max-width:300px;color:rgb(26,40,77);font-size:12px" class=""><div style="color:rgb(34,34,34);font-size:small" class=""><b class=""><font class="">Shayne Fletcher</font></b><br class=""></div><div style="font-size:small;color:rgb(80,0,80)" class=""><font size="1" class=""><font color="#444444" class="">Language Engineer </font><font color="#0b5394" class=""><b class="">/</b></font><font color="#444444" class=""> +1 917 699 7663</font><br class=""></font></div><font size="1" style="color:rgb(34,34,34)" class=""><a href="https://digitalasset.com/" style="color:rgb(17,85,204)" target="_blank" class=""><b class=""><font color="#3d85c6" class="">Digital Asset</font></b></a><font style="color:rgb(26,40,77)" class="">, creators of </font><b class=""><a href="https://daml.com/" style="color:rgb(17,85,204)" target="_blank" class=""><font color="#3d85c6" class="">DAML</font></a></b></font><br class=""></div></div></div></div></div></div></div></div><div style="font-family:sans-serif;color:rgb(33,33,33);font-size:13px" class=""></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
<br class="">
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8000001907349px;background-color:rgb(255,255,255)" class="">This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at </span><a href="http://www.digitalasset.com/emaildisclaimer.html" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:12.8px;background-color:rgb(255,255,255)" target="_blank" class="">http://www.digitalasset.<wbr class="">com/emaildisclaimer.html</a><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8000001907349px;background-color:rgb(255,255,255)" class="">. If you are not the intended recipient, please delete this message.</span>_______________________________________________<br class="">ghc-devs mailing list<br class=""><a href="mailto:ghc-devs@haskell.org" class="">ghc-devs@haskell.org</a><br class="">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<br class=""></div></blockquote></div><br class=""></body></html>