<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Excellent work Sebastian. I confirm that the situation is resolved by <a href="https://gitlab.haskell.org/ghc/ghc/merge_requests/1743">https://gitlab.haskell.org/ghc/ghc/merge_requests/1743</a>.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Sep 16, 2019 at 5:23 PM Sebastian Graf <<a href="mailto:sgraf1337@gmail.com">sgraf1337@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Shayne,</div><div><br></div><div>Sorry to hear that! We didn't consider modularity at all and I would be happy to try to refactor in a way that would allow `ghc-lib-parser` to be properly separated again.</div><div>I'm fairly certain that I didn't directly touch anything parser related, but apparently the new cyclic import of PmOracle within TcRnTypes (which is also exposed from `ghc-lib-parser`) pulled in the other half of GHC.</div><div>I'll see if I can fix that tomorrow, if only by extracting a separate `Types`-style module.</div><div><br></div><div>Cheers,</div><div>Sebastian<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Am Mo., 16. Sept. 2019 um 22:04 Uhr schrieb Shayne Fletcher via ghc-devs <<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Some time back, the `ghc-lib` project split into two targets : `ghc-lib-parser` for those projects that just need to produce syntax trees and `ghc-lib` (re-exporting `ghc-lib-parser` modules) having the remaining modules for projects that need to go on and distill parse trees to Core. The idea of course was to reduce build times for tools like hlint that only need parse trees.<br><br>Roughly, `ghc-lib-parser` got about 200 files and `ghc-lib` 300. Today after landing `7915afc6bb9539a4534db99aeb6616a6d145918a`, "Encode shape information in `PmOracle`", `ghc-lib-parser` now needs 543 files and `ghc-lib` gets just 25.<br><br>That may be just bad luck for `ghc-lib-parser` and the way it has to be but I thought I should at least mention the knock-on effect of this change on the modularity of the GHC API in case this consequence hasn't been considered?<br></div><div><br></div>-- <br><div dir="ltr" class="gmail-m_-8753502130116894180gmail-m_8921267182079084748gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div style="letter-spacing:normal;padding:10px 0px 10px 10px;width:300px;max-width:300px;color:rgb(26,40,77);font-size:12px"><div style="color:rgb(33,33,33);font-size:13px"><div><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div style="padding:10px 0px 10px 10px;width:300px;max-width:300px;color:rgb(26,40,77);font-size:12px"><div style="color:rgb(34,34,34);font-size:small"><b><font color="#000000">Shayne Fletcher</font></b><br></div><div style="font-size:small;color:rgb(80,0,80)"><font size="1"><font color="#444444">Language Engineer </font><font color="#0b5394"><b>/</b></font><font color="#444444"> +1 917 699 7663</font><br></font></div><font style="color:rgb(34,34,34)" size="1"><a href="https://digitalasset.com/" style="color:rgb(17,85,204)" target="_blank"><b><font color="#3d85c6">Digital Asset</font></b></a><font style="color:rgb(26,40,77)">, creators of </font><b><a href="https://daml.com/" style="color:rgb(17,85,204)" target="_blank"><font color="#3d85c6">DAML</font></a></b></font><br></div></div></div></div></div></div></div></div><div style="font-family:sans-serif;color:rgb(33,33,33);font-size:13px"></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
<br>
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;background-color:rgb(255,255,255)">This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at </span><a href="http://www.digitalasset.com/emaildisclaimer.html" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:12.8px;background-color:rgb(255,255,255)" target="_blank">http://www.digitalasset.com/emaildisclaimer.html</a><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;background-color:rgb(255,255,255)">. If you are not the intended recipient, please delete this message.</span>_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div style="letter-spacing:normal;padding:10px 0px 10px 10px;width:300px;max-width:300px;color:rgb(26,40,77);font-size:12px"><div style="color:rgb(33,33,33);font-size:13px"><div><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div style="padding:10px 0px 10px 10px;width:300px;max-width:300px;color:rgb(26,40,77);font-size:12px"><div style="color:rgb(34,34,34);font-size:small"><b><font color="#000000">Shayne Fletcher</font></b><br></div><div style="font-size:small;color:rgb(80,0,80)"><font size="1"><font color="#444444">Language Engineer </font><font color="#0b5394"><b>/</b></font><font color="#444444"> +1 917 699 7663</font><br></font></div><font size="1" style="color:rgb(34,34,34)"><a href="https://digitalasset.com/" style="color:rgb(17,85,204)" target="_blank"><b><font color="#3d85c6">Digital Asset</font></b></a><font style="color:rgb(26,40,77)">, creators of </font><b><a href="https://daml.com/" style="color:rgb(17,85,204)" target="_blank"><font color="#3d85c6">DAML</font></a></b></font><br></div></div></div></div></div></div></div></div><div style="font-family:sans-serif;color:rgb(33,33,33);font-size:13px"></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
<br>
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8000001907349px;background-color:rgb(255,255,255)">This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at </span><a href="http://www.digitalasset.com/emaildisclaimer.html" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:12.8px;background-color:rgb(255,255,255)" target="_blank">http://www.digitalasset.<wbr>com/emaildisclaimer.html</a><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8000001907349px;background-color:rgb(255,255,255)">. If you are not the intended recipient, please delete this message.</span>