<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
p.Code, li.Code, div.Code
{mso-style-name:Code;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:22.7pt;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;
font-weight:bold;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:238370555;
mso-list-template-ids:-1410142124;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1
{mso-list-id:907229496;
mso-list-template-ids:-1767606340;}
@list l1:level1
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level2
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level5
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level8
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l2
{mso-list-id:979725905;
mso-list-type:hybrid;
mso-list-template-ids:-938426558 134807553 134807555 134807557 134807553 134807555 134807557 134807553 134807555 134807557;}
@list l2:level1
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l2:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l2:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l2:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l2:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l2:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l2:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l2:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l2:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l3
{mso-list-id:1125808578;
mso-list-type:hybrid;
mso-list-template-ids:-779480018 134807553 134807555 134807557 134807553 134807555 134807557 134807553 134807555 134807557;}
@list l3:level1
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l3:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l3:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l3:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l3:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l3:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l3:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l3:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l3:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">David<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Ben writes (on #16586) <o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><a href="/simonpj" title="Simon Peyton Jones">@simonpj</a>, in general GHC HQ sets the milestone during triage (which I did in this case; I only realized that Iavor had submitted an MR after I left the comment
requesting that he set the milestone).<span style="color:windowtext;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Could you include this point in your workflow revisions?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Simon<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext">From:</span></b><span lang="EN-US" style="color:windowtext"> David Eichmann <davide@well-typed.com>
<br>
<b>Sent:</b> 27 May 2019 16:57<br>
<b>To:</b> GHC developers <ghc-devs@haskell.org><br>
<b>Cc:</b> Ben Gamari <ben@well-typed.com>; Simon Peyton Jones <simonpj@microsoft.com><br>
<b>Subject:</b> Re: Processing MRs very slow?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Simon, your suggestion makes sense to me. We can have 3 pages that cover:<o:p></o:p></p>
<p>1. Fixing Bugs (/working-conventions/fixing-bugs)<o:p></o:p></p>
<p>2. Adding Features (/working-conventions/adding-features)<o:p></o:p></p>
<p>3. Merge request work-flow (New page e.g. (/working-conventions/merge-requests)<o:p></o:p></p>
<p>Then (1) and (2) would reference (3) and most of the content in /home would be moved to (3).<o:p></o:p></p>
<p>This leave one loose end: /home is left almost empty. I suggest we move contents of
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fcontributing&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276113766&sdata=I%2BaasIWX5JaklGTPOueIQyXVDoDOxtSwTOclaJ5yKLM%3D&reserved=0">
/contributing</a> to /home, though I'm interested in hearing any alternative idea<o:p></o:p></p>
<p>- David E<o:p></o:p></p>
<p><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 5/23/19 12:24 PM, Simon Peyton Jones wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Thanks
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<pre style="margin-left:36.0pt">* I've noted this in <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fworking-conventions%2Ffixing-bugs&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276123771&sdata=AtMRnJAcHXmS4OttZHbLUXqio3VX08bDYNAwgwUhexQ%3D&reserved=0">fixing-bugs</a> and linked to <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fhome&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276123771&sdata=8vTj825a%2BbN0fxlZJDlsX07c3xWw%2FhFBvRyy3QowCEc%3D&reserved=0">home</a> (I'm trying to avoid too much duplication between <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fworking-conventions%2Ffixing-bugs&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276133781&sdata=d2JTpJu3fJhZI4SnceqFH1q%2FtgGjTRdltBq6mEU0LG0%3D&reserved=0">https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/fixing-bugs</a> and <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fhome&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276133781&sdata=9Drmt2TUBBZrmjHHEjUt85JaCLbMf5e8MYETZTiFwjs%3D&reserved=0">https://gitlab.haskell.org/ghc/ghc/wikis/home</a>)<o:p></o:p></pre>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">I agree with avoiding duplication, but let’s fix that by fixing the home page. Why is there all this detail about merge requests there? Let’s push all that off into a single integrated
page “How to contribute a patch”.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">The current “how to contribute a patch” page is really “how to fix a bug (including how to contribute a patch)”. So maybe we should have:</span><o:p></o:p></p>
<ul style="margin-top:0cm" type="disc">
<li class="MsoListParagraph" style="color:windowtext;margin-left:0cm;mso-list:l3 level1 lfo3">
<span style="mso-fareast-language:EN-US">How to fix a bug</span><o:p></o:p></li><li class="MsoListParagraph" style="color:windowtext;margin-left:0cm;mso-list:l3 level1 lfo3">
<span style="mso-fareast-language:EN-US">How to add a feature</span><o:p></o:p></li></ul>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">both as pages of their own, but both pointing to a single pate</span><o:p></o:p></p>
<ul style="margin-top:0cm" type="disc">
<li class="MsoListParagraph" style="color:windowtext;margin-left:0cm;mso-list:l2 level1 lfo6">
<span style="mso-fareast-language:EN-US">The mechanics of contributing a patch (bug or feature)</span><o:p></o:p></li></ul>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">That would also de-clutter the home page.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Simon</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext">From:</span></b><span lang="EN-US" style="color:windowtext"> David Eichmann
<a href="mailto:davide@well-typed.com"><davide@well-typed.com></a> <br>
<b>Sent:</b> 23 May 2019 12:10<br>
<b>To:</b> Simon Peyton Jones <a href="mailto:simonpj@microsoft.com"><simonpj@microsoft.com></a>; Ben Gamari
<a href="mailto:ben@well-typed.com"><ben@well-typed.com></a><br>
<b>Cc:</b> <a href="mailto:iavor.diatchki@gmail.com">iavor.diatchki@gmail.com</a><br>
<b>Subject:</b> Re: Processing MRs very slow?</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p>I found the email you're referring to <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.haskell.org%2Fpipermail%2Fghc-devs%2F2019-May%2F017656.html&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276143786&sdata=gDWiLjuJFYjt6VGTFwWHHifI7kJxAvUKrXWE9FNKxHI%3D&reserved=0">
https://mail.haskell.org/pipermail/ghc-devs/2019-May/017656.html</a>. You mentioned 3 points of missing information:<o:p></o:p></p>
<pre>* Picking approvers<o:p></o:p></pre>
<pre> * Lets see how the "gitlab upgrade - change in approval system" email thread develops.<o:p></o:p></pre>
<pre>* Assigning to Marge<o:p></o:p></pre>
<pre> * I've noted this in <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fworking-conventions%2Ffixing-bugs&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276143786&sdata=1XIMGLsGim1pairxM5%2BThX7yfHDn%2F1u1q%2FhMVE5aOlk%3D&reserved=0">fixing-bugs</a> and linked to <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fhome&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276153795&sdata=xDOORFUwGktCwbFCHsgHEPzGZ9DvG%2BuHtHqf%2FY3ic4E%3D&reserved=0">home</a> (I'm trying to avoid too much duplication between <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fworking-conventions%2Ffixing-bugs&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276163809&sdata=3HdLeAAHDshcHzfTmgZCEnWs9x%2FphWHK7JyhhFrS3C8%3D&reserved=0">https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/fixing-bugs</a> and <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fhome&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276163809&sdata=WmDLy%2BpI7LsF7VFkZiUfQubLyD1fVYhYXhLv0IojXWI%3D&reserved=0">https://gitlab.haskell.org/ghc/ghc/wikis/home</a>)<o:p></o:p></pre>
<pre>* Monitoring progress if it doesn't land within 24 hrs; even knowing when to time out would help.<o:p></o:p></pre>
<pre> * I've added some info in <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fhome%23merging-your-merge-request&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276173805&sdata=%2BkmfGafsI9CUyMnrBqM7ttvxwhNaKD9GEIfz52j1UDQ%3D&reserved=0">https://gitlab.haskell.org/ghc/ghc/wikis/home#merging-your-merge-request</a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Hope this is better now. Ben maybe you'd like to double check the bullet list in <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fwikis%2Fhome%23merging-your-merge-request&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276173805&sdata=%2BkmfGafsI9CUyMnrBqM7ttvxwhNaKD9GEIfz52j1UDQ%3D&reserved=0">https://gitlab.haskell.org/ghc/ghc/wikis/home#merging-your-merge-request</a> for the conditions under which marge will batch your MR.<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>- David E<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<div>
<p class="MsoNormal">On 5/23/19 9:02 AM, Simon Peyton Jones wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>| | Perhaps it is worth updating Step 7 or 8 of<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Yes, I suggested that to Ben a week or two ago, but he's flat out on incremental GC.<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Maybe David could do it? I can dig out the email.<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Thanks!<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Simon<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>| -----Original Message-----<o:p></o:p></pre>
<pre>| From: ghc-devs <a href="mailto:ghc-devs-bounces@haskell.org"><ghc-devs-bounces@haskell.org></a> On Behalf Of Iavor Diatchki<o:p></o:p></pre>
<pre>| Sent: 22 May 2019 23:49<o:p></o:p></pre>
<pre>| To: David Eichmann <a href="mailto:davide@well-typed.com"><davide@well-typed.com></a><o:p></o:p></pre>
<pre>| Cc: ghc-devs <a href="mailto:ghc-devs@haskell.org"><ghc-devs@haskell.org></a><o:p></o:p></pre>
<pre>| Subject: Re: Processing MRs very slow?<o:p></o:p></pre>
<pre>| <o:p></o:p></pre>
<pre>| Great thanks! How can I have a look at Marge-bot's queue?<o:p></o:p></pre>
<pre>| <o:p></o:p></pre>
<pre>| Perhaps it is worth updating Step 7 or 8 of<o:p></o:p></pre>
<pre>| <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h</a><o:p></o:p></pre>
<pre>| askell.org%2Fghc%2Fghc%2Fwikis%2Fworking-conventions%2Ffixing-<o:p></o:p></pre>
<pre>| bugs&data=02%7C01%7Csimonpj%40microsoft.com%7Cc0e7235773dd4c553d8c08d6<o:p></o:p></pre>
<pre>| df07cbb3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636941621907873036&a<o:p></o:p></pre>
<pre>| mp;sdata=gWoMbrHZwyfDQWeCst0VmAl4x%2Fv%2BjFY3dUXI7X%2FCHEQ%3D&reserved<o:p></o:p></pre>
<pre>| =0<o:p></o:p></pre>
<pre>| to indicate that the reviewers should assign the MR to Marge-bot when it<o:p></o:p></pre>
<pre>| is approved, and how one can check if that has happened.<o:p></o:p></pre>
<pre>| <o:p></o:p></pre>
<pre>| <o:p></o:p></pre>
<pre>| On Wed, May 22, 2019 at 9:53 AM David Eichmann <a href="mailto:davide@well-typed.com"><davide@well-typed.com></a><o:p></o:p></pre>
<pre>| wrote:<o:p></o:p></pre>
<pre>| ><o:p></o:p></pre>
<pre>| > Recently there have been some issues with CI that has slowed down<o:p></o:p></pre>
<pre>| > merging. In particular a performance test (T9630) was failing on CI.<o:p></o:p></pre>
<pre>| > That is fixed now and as of today Marge-Bot seems to be merging MRs<o:p></o:p></pre>
<pre>| > again. I'll continue to monitor this in the coming days.<o:p></o:p></pre>
<pre>| ><o:p></o:p></pre>
<pre>| > Iavor, your MR was approved but not assigned to Marge-bot, and so was<o:p></o:p></pre>
<pre>| > not in the merge queue. I'm not sure who has permission to do this,<o:p></o:p></pre>
<pre>| > but you can always ping the approvers. In this case I've assigned to<o:p></o:p></pre>
<pre>| > Marge-bot for you, and it will hopefully be merge soon.<o:p></o:p></pre>
<pre>| ><o:p></o:p></pre>
<pre>| > David Eichmann<o:p></o:p></pre>
<pre>| ><o:p></o:p></pre>
<pre>| > On 5/22/19 5:09 PM, Iavor Diatchki wrote:<o:p></o:p></pre>
<pre>| > > Hello,<o:p></o:p></pre>
<pre>| > ><o:p></o:p></pre>
<pre>| > > I made a gitlab MR that adds two NOINLINE pragmas and some comments.<o:p></o:p></pre>
<pre>| > > It's been about a week since my last push to the MR, and nothing has<o:p></o:p></pre>
<pre>| > > happened since.<o:p></o:p></pre>
<pre>| > ><o:p></o:p></pre>
<pre>| > > Is there a way to check on what is its status:<o:p></o:p></pre>
<pre>| > > - Is it stuck because I need to do something?<o:p></o:p></pre>
<pre>| > > - Is it stuck because someone else needs to do something?<o:p></o:p></pre>
<pre>| > > - Or is it just in the queue to be merged, in which case it would<o:p></o:p></pre>
<pre>| > > be nice to know where in line it is, so I can see that there is<o:p></o:p></pre>
<pre>| > > progress, and it is not just stuck.<o:p></o:p></pre>
<pre>| > ><o:p></o:p></pre>
<pre>| > > Given that this is such a simple MR, I am not too worried about<o:p></o:p></pre>
<pre>| > > conflicts but a week long lag seems less than ideal for anything<o:p></o:p></pre>
<pre>| > > even mildly complex.<o:p></o:p></pre>
<pre>| > ><o:p></o:p></pre>
<pre>| > > -Iavor<o:p></o:p></pre>
<pre>| > ><o:p></o:p></pre>
<pre>| > > PS: I just clicked on all the little check boxes from the<o:p></o:p></pre>
<pre>| > > template---perhaps that's why things weren't progressing?<o:p></o:p></pre>
<pre>| > > _______________________________________________<o:p></o:p></pre>
<pre>| > > ghc-devs mailing list<o:p></o:p></pre>
<pre>| > > <a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><o:p></o:p></pre>
<pre>| > > <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmai">https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmai</a><o:p></o:p></pre>
<pre>| > > l.haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=02%<o:p></o:p></pre>
<pre>| > > 7C01%7Csimonpj%40microsoft.com%7Cc0e7235773dd4c553d8c08d6df07cbb3%7C<o:p></o:p></pre>
<pre>| > > 72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636941621907873036&sd<o:p></o:p></pre>
<pre>| > > ata=W3wnIH%2F2oEmuqona%2Fk6NtoYUZsnFA1kun%2Blm%2BSGMIjo%3D&reser<o:p></o:p></pre>
<pre>| > > ved=0<o:p></o:p></pre>
<pre>| ><o:p></o:p></pre>
<pre>| > --<o:p></o:p></pre>
<pre>| > David Eichmann, Haskell Consultant<o:p></o:p></pre>
<pre>| > Well-Typed LLP,<o:p></o:p></pre>
<pre>| > <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w">https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w</a><o:p></o:p></pre>
<pre>| > ell-typed.com&data=02%7C01%7Csimonpj%40microsoft.com%7Cc0e7235773d<o:p></o:p></pre>
<pre>| > d4c553d8c08d6df07cbb3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636<o:p></o:p></pre>
<pre>| > 941621907873036&sdata=RIcEblo4xNED7UY6Vv%2FNIG4aAzcjLgzN8uegqX9K%2<o:p></o:p></pre>
<pre>| > F3I%3D&reserved=0<o:p></o:p></pre>
<pre>| ><o:p></o:p></pre>
<pre>| > Registered in England & Wales, OC335890<o:p></o:p></pre>
<pre>| > 118 Wymering Mansions, Wymering Road, London W9 2NF, England<o:p></o:p></pre>
<pre>| ><o:p></o:p></pre>
<pre>| > _______________________________________________<o:p></o:p></pre>
<pre>| > ghc-devs mailing list<o:p></o:p></pre>
<pre>| > <a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><o:p></o:p></pre>
<pre>| > <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail">https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail</a>.<o:p></o:p></pre>
<pre>| > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=02%7C01<o:p></o:p></pre>
<pre>| > %7Csimonpj%40microsoft.com%7Cc0e7235773dd4c553d8c08d6df07cbb3%7C72f988<o:p></o:p></pre>
<pre>| > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636941621907873036&sdata=W3wn<o:p></o:p></pre>
<pre>| > IH%2F2oEmuqona%2Fk6NtoYUZsnFA1kun%2Blm%2BSGMIjo%3D&reserved=0<o:p></o:p></pre>
<pre>| _______________________________________________<o:p></o:p></pre>
<pre>| ghc-devs mailing list<o:p></o:p></pre>
<pre>| <a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><o:p></o:p></pre>
<pre>| <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask">https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask</a><o:p></o:p></pre>
<pre>| ell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-<o:p></o:p></pre>
<pre>| devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cc0e7235773dd4c553d8c08d6<o:p></o:p></pre>
<pre>| df07cbb3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636941621907873036&a<o:p></o:p></pre>
<pre>| mp;sdata=W3wnIH%2F2oEmuqona%2Fk6NtoYUZsnFA1kun%2Blm%2BSGMIjo%3D&reserv<o:p></o:p></pre>
<pre>| ed=0<o:p></o:p></pre>
</blockquote>
<pre>-- <o:p></o:p></pre>
<pre>David Eichmann, Haskell Consultant<o:p></o:p></pre>
<pre>Well-Typed LLP, <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.well-typed.com&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276183814&sdata=iL6TkG%2FXU%2BKJyCl6uANDSqUE6zBjMyiv%2Bxrqj0lqeXs%3D&reserved=0">http://www.well-typed.com</a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Registered in England & Wales, OC335890<o:p></o:p></pre>
<pre>118 Wymering Mansions, Wymering Road, London W9 2NF, England <o:p></o:p></pre>
</div>
</blockquote>
<pre>-- <o:p></o:p></pre>
<pre>David Eichmann, Haskell Consultant<o:p></o:p></pre>
<pre>Well-Typed LLP, <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.well-typed.com&data=02%7C01%7Csimonpj%40microsoft.com%7C80357e1c29b34640c70b08d6e2bbf6ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636945694276183814&sdata=iL6TkG%2FXU%2BKJyCl6uANDSqUE6zBjMyiv%2Bxrqj0lqeXs%3D&reserved=0">http://www.well-typed.com</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Registered in England & Wales, OC335890<o:p></o:p></pre>
<pre>118 Wymering Mansions, Wymering Road, London W9 2NF, England <o:p></o:p></pre>
</div>
</div>
</body>
</html>