<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I confirm that I see "Unresolve discussion" buttons in the "Discussion" page, after "Toggle Discussion" is clicked.<div class=""><br class=""></div><div class="">Perhaps we have this working convention: the dev that starts the discussion is expected to resolve it. I doubt GL can enforce that convention, but we can just agree to it all. So, in the case at hand, I wrote the patch, and Simon started several discussions. As I address them, instead of resolving the discussions (as I did), I would just say "Done" (or similar). Then, Simon's re-review would spot my comments and then click resolve, when the matter has met his satisfaction.</div><div class=""><br class=""></div><div class="">Ben: I imagine this will not be the only such convention we arrive at in this vein. Is it possible (and reasonably easy) to set up some service whereby new contributors get a "welcome" email upon their first submission of an MR? (But only upon the *first* submission!) This would include hearty thanks for contributing, etc., but also a few GL pointers and our working conventions. To be honest, even forgetting about working conventions, an email of thanks at that stage would probably set the stage for a nice working environment for contributors. (Right now, they probably submit, get some silence, then see a slew of comments telling them what they've done wrong, and then get a "Thanks so much!" after all those negative comments. This may be somewhat standard in open-source -- and isn't so bad that it *needs* change -- but that doesn't mean we can't do better.)</div><div class=""><br class=""></div><div class="">Richard<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 14, 2019, at 7:30 AM, Mikolaj Konarski <<a href="mailto:mikolaj@well-typed.com" class="">mikolaj@well-typed.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">On Mon, Jan 14, 2019 at 10:28 AM Simon Peyton Jones via ghc-devs <<a href="mailto:ghc-devs@haskell.org" class="">ghc-devs@haskell.org</a>> wrote:</div><div class="">></div><div class="">> I suppose we could issue guidance NEVER to resolve a discussion, but that seems like the wrong conclusion.</div><br class="">It seems gitlab's "resolve discussion" action is supposed to mean<br class="">"I think nobody needs to look at these comments (in detail) any more".<br class=""><br class="">So if somebody addressed your comment, he should probably<br class="">ping you with "this comment addressed", then you look at the comment,<br class="">at the old diff, at the new diff (no idea how easy it is to switch between<br class="">the old and new diffs) and then *you* resolve the discussion, if satisfied.<br class="">And if somebody resolves discussion prematurely, you unresolve it<br class="">with the button or checkbox, meaning "actually, I'd like to have<br class="">one more close look before the discussion is hidden forever".<br class="">You can even add an unresolve comment explaining why you think<br class="">the additional look is needed after all.<br class=""><br class="">All this is quite troublesome if there is a lot of comments<br class="">and they need to be pinged about, resolved and unresolved<br class="">in bulk (unless I'm missing some bulk button).<br class=""><div class=""></div><br class=""></div>
_______________________________________________<br class="">ghc-devs mailing list<br class=""><a href="mailto:ghc-devs@haskell.org" class="">ghc-devs@haskell.org</a><br class="">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<br class=""></div></blockquote></div><br class=""></div></body></html>